aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authordaniellizewski <daniellizewski@geotab.com>2024-08-23 08:31:04 -0400
committerAntonio Borneo <borneo.antonio@gmail.com>2024-09-15 09:07:12 +0000
commitd35399b00e5693d5b6f91208b0f52e5d710d086f (patch)
tree200b91bc67baf6716cdc489b507a8c0a960ac262
parent6f9b1ee521203f0d43b7d84e671ba4e32bd3e599 (diff)
downloadriscv-openocd-d35399b00e5693d5b6f91208b0f52e5d710d086f.zip
riscv-openocd-d35399b00e5693d5b6f91208b0f52e5d710d086f.tar.gz
riscv-openocd-d35399b00e5693d5b6f91208b0f52e5d710d086f.tar.bz2
src/flash/nor/kinetis.c: Fixed flash bank write gap
Flash banks created in kinetis_create_missing_banks did not populate bank->minimal_write_gap. The default value of 0 was interpreted as FLASH_WRITE_CONTINUOUS. This created unnecessary large padding if your binary had a gap in the populated flash. It also caused flash errors when loading with GDB because the erroneously padded pages were not erased first. Tested using an S32k148 using s32k.cfg. Change-Id: I9b7af698e29ac2c4f5fc8ecd82fa7f4b1a0d43f1 Signed-off-by: daniellizewski <daniellizewski@geotab.com> Reviewed-on: https://review.openocd.org/c/openocd/+/8463 Tested-by: jenkins Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com> Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
-rw-r--r--src/flash/nor/kinetis.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/src/flash/nor/kinetis.c b/src/flash/nor/kinetis.c
index fee3644..2d0a753 100644
--- a/src/flash/nor/kinetis.c
+++ b/src/flash/nor/kinetis.c
@@ -1038,6 +1038,7 @@ static int kinetis_create_missing_banks(struct kinetis_chip *k_chip)
bank->target = k_chip->target;
bank->driver = &kinetis_flash;
bank->default_padded_value = bank->erased_value = 0xff;
+ bank->minimal_write_gap = FLASH_WRITE_GAP_SECTOR;
snprintf(name, sizeof(name), "%s.%s%s",
base_name, class, num);