From e1f88be374e98df1dcc075e17a3d515d7daad6c2 Mon Sep 17 00:00:00 2001 From: Tim Newsome Date: Wed, 19 Jul 2023 13:09:18 -0700 Subject: debug: Only run pylint if debug files changed. --- .github/workflows/debug.yml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/debug.yml b/.github/workflows/debug.yml index 29ca5b2..7b6beb4 100644 --- a/.github/workflows/debug.yml +++ b/.github/workflows/debug.yml @@ -1,6 +1,9 @@ -on: pull_request +on: + pull_request: + paths: + - 'debug/**' -name: Check Code Style (checkpatch) +name: Check Debug Code Style (pylint) jobs: check: -- cgit v1.1 From 49ea5933fe54084b2bad4a76637559f087f578c4 Mon Sep 17 00:00:00 2001 From: Tim Newsome Date: Wed, 19 Jul 2023 13:14:33 -0700 Subject: debug: Better comment the privilege tests. Just doing this to make a change in the debug files, which should now cause the pylint workflow to execute. --- debug/gdbserver.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/debug/gdbserver.py b/debug/gdbserver.py index 53eeffa..3b9a661 100755 --- a/debug/gdbserver.py +++ b/debug/gdbserver.py @@ -1562,6 +1562,7 @@ class DownloadTest(GdbTest): # assertIn("0xbead", output) class PrivTest(GdbSingleHartTest): + """Base class for a few tests that change privilege levels.""" compile_args = ("programs/priv.S", ) def setup(self): # pylint: disable=attribute-defined-outside-init @@ -1588,8 +1589,8 @@ class PrivTest(GdbSingleHartTest): pass class PrivRw(PrivTest): + """Test reading/writing priv.""" def test(self): - """Test reading/writing priv.""" self.write_nop_program(4) for privilege in range(4): self.gdb.p(f"$priv={privilege}") @@ -1600,9 +1601,9 @@ class PrivRw(PrivTest): assertEqual(actual, privilege) class PrivChange(PrivTest): + """Test that the core's privilege level actually changes when the debugger + writes it.""" def test(self): - """Test that the core's privilege level actually changes.""" - if 0 not in self.supported: raise TestNotApplicable -- cgit v1.1