From 9542cb7c3d9f4b66d2df3d8412a73d008077ab86 Mon Sep 17 00:00:00 2001 From: Tomas Vanek Date: Thu, 15 Nov 2018 12:19:25 +0100 Subject: flash/nor: consolidate flash protect/protect_check Make flash_driver methods protect() and protect_check() optional. Remove dummy definitions of these methods from the drivers which do not implement protection handling. Some drivers did not define protect method. It raised segfault before this change and now it is handled properly. Lot of drivers returned ERROR_OK from dummy protect() - now flash_driver_protect() returns an error if not handled by the driver. Change-Id: I2d4a0da316bf03c6379791b1b1c6198fbf22e66c Signed-off-by: Tomas Vanek Reviewed-on: http://openocd.zylin.com/4765 Tested-by: jenkins Reviewed-by: Andreas Bolsch Reviewed-by: Christopher Head --- src/flash/nor/lpc288x.c | 1 + 1 file changed, 1 insertion(+) (limited to 'src/flash/nor/lpc288x.c') diff --git a/src/flash/nor/lpc288x.c b/src/flash/nor/lpc288x.c index 2472913..474e721 100644 --- a/src/flash/nor/lpc288x.c +++ b/src/flash/nor/lpc288x.c @@ -167,6 +167,7 @@ static int lpc288x_read_part_info(struct flash_bank *bank) return ERROR_OK; } +/* TODO: Revisit! Is it impossible to read protection status? */ static int lpc288x_protect_check(struct flash_bank *bank) { return ERROR_OK; -- cgit v1.1