From abc065fa941f67aae994ca72c65405b971f7b72a Mon Sep 17 00:00:00 2001 From: Tim Newsome Date: Tue, 29 Nov 2022 10:47:38 -0800 Subject: Move exit() into GdbTest(). --- debug/gdbserver.py | 15 --------------- debug/programs/trigger.S | 2 +- debug/testlib.py | 8 ++++++++ 3 files changed, 9 insertions(+), 16 deletions(-) diff --git a/debug/gdbserver.py b/debug/gdbserver.py index 08e8f4f..3cb7f32 100755 --- a/debug/gdbserver.py +++ b/debug/gdbserver.py @@ -467,14 +467,6 @@ class ProgramTest(GdbSingleHartTest): def setup(self): self.gdb.load() - def exit(self, expected_result=10): - self.gdb.command("delete") - self.gdb.b("_exit") - output = self.gdb.c() - assertIn("Breakpoint", output) - assertIn("_exit", output) - assertEqual(self.gdb.p("status"), expected_result) - class ProgramHwWatchpoint(ProgramTest): def test(self): mainbp = self.gdb.b("main") @@ -1323,13 +1315,6 @@ class TriggerTest(GdbSingleHartTest): self.gdb.c() self.gdb.command("delete") - def exit(self): - self.gdb.command("delete") - self.gdb.b("_exit") - output = self.gdb.c() - assertIn("Breakpoint", output) - assertIn("_exit", output) - class TriggerExecuteInstant(TriggerTest): """Test an execute breakpoint on the first instruction executed out of debug mode.""" diff --git a/debug/programs/trigger.S b/debug/programs/trigger.S index 4b3da91..1e8be07 100644 --- a/debug/programs/trigger.S +++ b/debug/programs/trigger.S @@ -60,7 +60,7 @@ clear_triggers: jal write_triggers main_exit: - li a0, 0 + li a0, 10 j _exit write_triggers: diff --git a/debug/testlib.py b/debug/testlib.py index d3fee5c..edb903a 100644 --- a/debug/testlib.py +++ b/debug/testlib.py @@ -1272,6 +1272,14 @@ class GdbTest(BaseTest): # PMP registers are optional pass + def exit(self, expected_result=10): + self.gdb.command("delete") + self.gdb.b("_exit") + output = self.gdb.c() + assertIn("Breakpoint", output) + assertIn("_exit", output) + assertEqual(self.gdb.p("status"), expected_result) + class GdbSingleHartTest(GdbTest): def classSetup(self): GdbTest.classSetup(self) -- cgit v1.1