aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRyan Buchner <ryan.buchner@arilinc.com>2023-04-17 19:19:01 -0700
committerrbuchner <ryan.buchner@arilinc.com>2023-05-11 23:00:58 -0700
commit87690a5ed4b55a3938efac098ce68fbf4d7fb037 (patch)
tree4200e5ff768090c17c9b86a98cbf913364f2f470
parent8a34e1a5b3bc68b915127af15ea9254f7d812727 (diff)
downloadriscv-isa-sim-87690a5ed4b55a3938efac098ce68fbf4d7fb037.zip
riscv-isa-sim-87690a5ed4b55a3938efac098ce68fbf4d7fb037.tar.gz
riscv-isa-sim-87690a5ed4b55a3938efac098ce68fbf4d7fb037.tar.bz2
Adjust load_slow_path_intrapage to recieve a mem_access_info_t as input
-rw-r--r--riscv/mmu.cc20
-rw-r--r--riscv/mmu.h2
2 files changed, 12 insertions, 10 deletions
diff --git a/riscv/mmu.cc b/riscv/mmu.cc
index e2341fb..34cd170 100644
--- a/riscv/mmu.cc
+++ b/riscv/mmu.cc
@@ -190,18 +190,19 @@ void mmu_t::check_triggers(triggers::operation_t operation, reg_t address, std::
}
}
-void mmu_t::load_slow_path_intrapage(reg_t addr, reg_t len, uint8_t* bytes, xlate_flags_t xlate_flags)
+void mmu_t::load_slow_path_intrapage(reg_t len, uint8_t* bytes, mem_access_info_t access_info)
{
+ reg_t addr = access_info.vaddr;
reg_t vpn = addr >> PGSHIFT;
- if (!xlate_flags.is_special_access() && vpn == (tlb_load_tag[vpn % TLB_ENTRIES] & ~TLB_CHECK_TRIGGERS)) {
+ if (!access_info.flags.is_special_access() && vpn == (tlb_load_tag[vpn % TLB_ENTRIES] & ~TLB_CHECK_TRIGGERS)) {
auto host_addr = tlb_data[vpn % TLB_ENTRIES].host_offset + addr;
memcpy(bytes, host_addr, len);
return;
}
- reg_t paddr = translate(generate_access_info(addr, LOAD, xlate_flags), len);
+ reg_t paddr = translate(access_info, len);
- if (xlate_flags.lr && !sim->reservable(paddr)) {
+ if (access_info.flags.lr && !sim->reservable(paddr)) {
throw trap_load_access_fault((proc) ? proc->state.v : false, addr, 0, 0);
}
@@ -209,24 +210,25 @@ void mmu_t::load_slow_path_intrapage(reg_t addr, reg_t len, uint8_t* bytes, xlat
memcpy(bytes, host_addr, len);
if (tracer.interested_in_range(paddr, paddr + PGSIZE, LOAD))
tracer.trace(paddr, len, LOAD);
- else if (!xlate_flags.is_special_access())
+ else if (!access_info.flags.is_special_access())
refill_tlb(addr, paddr, host_addr, LOAD);
} else if (!mmio_load(paddr, len, bytes)) {
throw trap_load_access_fault((proc) ? proc->state.v : false, addr, 0, 0);
}
- if (xlate_flags.lr) {
+ if (access_info.flags.lr) {
load_reservation_address = paddr;
}
}
void mmu_t::load_slow_path(reg_t addr, reg_t len, uint8_t* bytes, xlate_flags_t xlate_flags)
{
+ auto access_info = generate_access_info(addr, LOAD, xlate_flags);
check_triggers(triggers::OPERATION_LOAD, addr);
if ((addr & (len - 1)) == 0) {
- load_slow_path_intrapage(addr, len, bytes, xlate_flags);
+ load_slow_path_intrapage(len, bytes, access_info);
} else {
bool gva = ((proc) ? proc->state.v : false) || xlate_flags.forced_virt;
if (!is_misaligned_enabled())
@@ -236,9 +238,9 @@ void mmu_t::load_slow_path(reg_t addr, reg_t len, uint8_t* bytes, xlate_flags_t
throw trap_load_access_fault(gva, addr, 0, 0);
reg_t len_page0 = std::min(len, PGSIZE - addr % PGSIZE);
- load_slow_path_intrapage(addr, len_page0, bytes, xlate_flags);
+ load_slow_path_intrapage(len_page0, bytes, access_info);
if (len_page0 != len)
- load_slow_path_intrapage(addr + len_page0, len - len_page0, bytes + len_page0, xlate_flags);
+ load_slow_path_intrapage(len - len_page0, bytes + len_page0, generate_access_info(addr + len_page0, LOAD, xlate_flags));
}
check_triggers(triggers::OPERATION_LOAD, addr, reg_from_bytes(len, bytes));
diff --git a/riscv/mmu.h b/riscv/mmu.h
index 1039de1..1d38849 100644
--- a/riscv/mmu.h
+++ b/riscv/mmu.h
@@ -379,7 +379,7 @@ private:
// handle uncommon cases: TLB misses, page faults, MMIO
tlb_entry_t fetch_slow_path(reg_t addr);
void load_slow_path(reg_t addr, reg_t len, uint8_t* bytes, xlate_flags_t xlate_flags);
- void load_slow_path_intrapage(reg_t addr, reg_t len, uint8_t* bytes, xlate_flags_t xlate_flags);
+ void load_slow_path_intrapage(reg_t len, uint8_t* bytes, mem_access_info_t access_info);
void store_slow_path(reg_t addr, reg_t len, const uint8_t* bytes, xlate_flags_t xlate_flags, bool actually_store, bool require_alignment);
void store_slow_path_intrapage(reg_t addr, reg_t len, const uint8_t* bytes, xlate_flags_t xlate_flags, bool actually_store);
bool mmio_fetch(reg_t paddr, size_t len, uint8_t* bytes);