From 190979b4fce6ded989338a0943feeb035db7b75a Mon Sep 17 00:00:00 2001 From: Xiang W Date: Wed, 19 Mar 2025 20:39:38 +0800 Subject: lib: sbi: Remove unnecessary SBI_INIT_LIST_HEAD No need to initialise the nodes to be added to the linked list Signed-off-by: Xiang W Reviewed-by: Samuel Holland Reviewed-by: Anup Patel Link: https://lore.kernel.org/r/20250319123944.505756-1-wxjstz@126.com Signed-off-by: Anup Patel --- lib/utils/fdt/fdt_fixup.c | 1 - lib/utils/mailbox/mailbox.c | 2 -- 2 files changed, 3 deletions(-) (limited to 'lib/utils') diff --git a/lib/utils/fdt/fdt_fixup.c b/lib/utils/fdt/fdt_fixup.c index 192d6dd..e237dd0 100644 --- a/lib/utils/fdt/fdt_fixup.c +++ b/lib/utils/fdt/fdt_fixup.c @@ -415,7 +415,6 @@ int fdt_register_general_fixup(struct fdt_general_fixup *fixup) return SBI_EALREADY; } - SBI_INIT_LIST_HEAD(&fixup->head); sbi_list_add_tail(&fixup->head, &fixup_list); return 0; diff --git a/lib/utils/mailbox/mailbox.c b/lib/utils/mailbox/mailbox.c index 2ea7a00..b3f7e8b 100644 --- a/lib/utils/mailbox/mailbox.c +++ b/lib/utils/mailbox/mailbox.c @@ -34,7 +34,6 @@ int mbox_controller_add(struct mbox_controller *mbox) if (mbox_controller_find(mbox->id)) return SBI_EALREADY; - SBI_INIT_LIST_HEAD(&mbox->node); ATOMIC_INIT(&mbox->xfer_next_seq, 0); SBI_INIT_LIST_HEAD(&mbox->chan_list); sbi_list_add(&mbox->node, &mbox_list); @@ -80,7 +79,6 @@ struct mbox_chan *mbox_controller_request_chan(struct mbox_controller *mbox, if (!ret) return NULL; - SBI_INIT_LIST_HEAD(&ret->node); ret->mbox = mbox; sbi_memcpy(ret->chan_args, chan_args, sizeof(ret->chan_args)); sbi_list_add(&ret->node, &mbox->chan_list); -- cgit v1.1