From ea5abd1f5e33ed3afedc92686ec8bfd00bc49235 Mon Sep 17 00:00:00 2001 From: Alvin Chang Date: Thu, 3 Jul 2025 23:19:56 +0800 Subject: lib: sbi: Remove redundant call to sbi_hart_expected_trap_addr() The variable "sbi_hart_expected_trap" has already been extern variable. Therefore, the program can directly refer to it instead of calling sbi_hart_expected_trap_addr(). Signed-off-by: Alvin Chang Reviewed-by: Anup Patel Link: https://lore.kernel.org/r/20250703151957.2545958-2-alvinga@andestech.com Signed-off-by: Anup Patel --- include/sbi/sbi_csr_detect.h | 4 ++-- include/sbi/sbi_hart.h | 4 ---- 2 files changed, 2 insertions(+), 6 deletions(-) (limited to 'include') diff --git a/include/sbi/sbi_csr_detect.h b/include/sbi/sbi_csr_detect.h index 89ba294..097c31c 100644 --- a/include/sbi/sbi_csr_detect.h +++ b/include/sbi/sbi_csr_detect.h @@ -18,7 +18,7 @@ ({ \ register ulong tinfo asm("a3") = (ulong)trap; \ register ulong ttmp asm("a4"); \ - register ulong mtvec = sbi_hart_expected_trap_addr(); \ + register ulong mtvec = (ulong)sbi_hart_expected_trap; \ register ulong ret = 0; \ ((struct sbi_trap_info *)(trap))->cause = 0; \ asm volatile( \ @@ -37,7 +37,7 @@ ({ \ register ulong tinfo asm("a3") = (ulong)trap; \ register ulong ttmp asm("a4"); \ - register ulong mtvec = sbi_hart_expected_trap_addr(); \ + register ulong mtvec = (ulong)sbi_hart_expected_trap; \ ((struct sbi_trap_info *)(trap))->cause = 0; \ asm volatile( \ "add %[ttmp], %[tinfo], zero\n" \ diff --git a/include/sbi/sbi_hart.h b/include/sbi/sbi_hart.h index dfbe8e4..82b19dc 100644 --- a/include/sbi/sbi_hart.h +++ b/include/sbi/sbi_hart.h @@ -134,10 +134,6 @@ int sbi_hart_reinit(struct sbi_scratch *scratch); int sbi_hart_init(struct sbi_scratch *scratch, bool cold_boot); extern void (*sbi_hart_expected_trap)(void); -static inline ulong sbi_hart_expected_trap_addr(void) -{ - return (ulong)sbi_hart_expected_trap; -} unsigned int sbi_hart_mhpm_mask(struct sbi_scratch *scratch); void sbi_hart_delegation_dump(struct sbi_scratch *scratch, -- cgit v1.1