From b4baf039588830dfd580a59e7d05efbc65cb6d03 Mon Sep 17 00:00:00 2001 From: John Levon Date: Tue, 16 Feb 2021 16:11:35 +0000 Subject: fix DEVICE_GET_INFO specification and handling (#344) The specification for DEVICE_GET_INFO differed from the implementation. After some discussion, fix the spec such that the struct should be passed in with ->argsz set. As it happened, the implementation was also wrong: we weren't actually checking the incoming ->argsz for validation, but we should. Signed-off-by: John Levon Reviewed-by: Thanos Makatos --- lib/private.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'lib/private.h') diff --git a/lib/private.h b/lib/private.h index 787cae9..edd7b68 100644 --- a/lib/private.h +++ b/lib/private.h @@ -177,7 +177,8 @@ consume_fd(int *fds, size_t nr_fds, size_t index); int handle_device_get_info(vfu_ctx_t *vfu_ctx, uint32_t size, - struct vfio_device_info *dev_info); + struct vfio_device_info *in_dev_info, + struct vfio_device_info *out_dev_info); long dev_get_reginfo(vfu_ctx_t *vfu_ctx, uint32_t index, uint32_t argsz, -- cgit v1.1