From c8ee10e29c668a30a8d10e8a16c570b1bbe32175 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Date: Mon, 27 Jan 2020 10:24:13 +0100 Subject: tcp_ctl: use slirp_fmt() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Make it safer to OOB (sb_cc must not go out of sb_data), warn on truncation, abort on error. Signed-off-by: Marc-André Lureau Reviewed-by: Samuel Thibault Message-Id: <20200127092414.169796-6-marcandre.lureau@redhat.com> --- src/tcp_subr.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'src/tcp_subr.c') diff --git a/src/tcp_subr.c b/src/tcp_subr.c index 7832b14..a699117 100644 --- a/src/tcp_subr.c +++ b/src/tcp_subr.c @@ -965,9 +965,8 @@ int tcp_ctl(struct socket *so) } } } - sb->sb_cc = - snprintf(sb->sb_wptr, sb->sb_datalen - (sb->sb_wptr - sb->sb_data), - "Error: No application configured.\r\n"); + sb->sb_cc = slirp_fmt(sb->sb_wptr, sb->sb_datalen - (sb->sb_wptr - sb->sb_data), + "Error: No application configured.\r\n"); sb->sb_wptr += sb->sb_cc; return 0; } -- cgit v1.1