From db0dd60b8c8de91ef3f6d66a2d0c2b62ab94c400 Mon Sep 17 00:00:00 2001 From: Peter Maydell Date: Fri, 14 Jul 2017 12:12:25 +0100 Subject: slirp: Handle error returns from sosendoob() sosendoob() can return a failure code, but all its callers ignore it. This is OK in sbappend(), as the comment there states -- we will try again later in sowrite(). Add a (void) cast to tell Coverity so. In sowrite() we do need to check the return value -- we should handle a write failure in sosendoob() the same way we handle a write failure for the normal data. Signed-off-by: Peter Maydell Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Samuel Thibault --- sbuf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'sbuf.c') diff --git a/sbuf.c b/sbuf.c index 8a0a6a9..01f9a46 100644 --- a/sbuf.c +++ b/sbuf.c @@ -88,7 +88,7 @@ void sbappend(struct socket *so, struct mbuf *m) if (so->so_urgc) { sbappendsb(&so->so_rcv, m); m_free(m); - sosendoob(so); + (void)sosendoob(so); return; } -- cgit v1.1