aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGuillaume Subiron <maethor@subiron.org>2015-12-19 22:24:55 +0100
committerJason Wang <jasowang@redhat.com>2016-02-04 13:22:06 +0800
commit33c25f72b160533bb1ec4ec1e38833af84e588e5 (patch)
treeca30e5fe2adc920ab96606a4a26bba6585b457d0
parentf40d9f18604adca951e33a9b25353c4d28bfca5a (diff)
downloadslirp-33c25f72b160533bb1ec4ec1e38833af84e588e5.zip
slirp-33c25f72b160533bb1ec4ec1e38833af84e588e5.tar.gz
slirp-33c25f72b160533bb1ec4ec1e38833af84e588e5.tar.bz2
slirp: goto bad in udp_input if sosendto fails
Before this patch, if sosendto fails, udp_input is executed as if the packet was sent, recording the packet for icmp errors, which does not makes sense since the packet was not actually sent, errors would be related to a previous packet. This patch adds a goto bad to cut the execution of this function. Signed-off-by: Guillaume Subiron <maethor@subiron.org> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org> Reviewed-by: Thomas Huth <thuth@redhat.com> Signed-off-by: Jason Wang <jasowang@redhat.com>
-rw-r--r--udp.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/udp.c b/udp.c
index e51af7e..85450cd 100644
--- a/udp.c
+++ b/udp.c
@@ -215,6 +215,7 @@ void udp_input(register struct mbuf *m, int iphlen)
*ip = save_ip;
DEBUG_MISC((dfd, "udp tx errno = %d-%s\n", errno, strerror(errno)));
icmp_error(m, ICMP_UNREACH, ICMP_UNREACH_NET, 0, strerror(errno));
+ goto bad;
}
m_free(so->so_m); /* used for ICMP if error on sorecvfrom */