aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMarek BehĂșn <marek.behun@nic.cz>2021-10-17 17:36:29 +0200
committerSimon Glass <sjg@chromium.org>2021-10-21 12:50:48 -0600
commit7b611ee90e1e4db531c4e3896efebfdc0743725d (patch)
tree6ec0e3f1490a30e5ae7900421b7176374215bb41
parent6aa652d008398fa7db99b7d570bc6f0123dcd9b5 (diff)
downloadu-boot-7b611ee90e1e4db531c4e3896efebfdc0743725d.zip
u-boot-7b611ee90e1e4db531c4e3896efebfdc0743725d.tar.gz
u-boot-7b611ee90e1e4db531c4e3896efebfdc0743725d.tar.bz2
env: Change env_match() to static and remove from header
This function was used by other parts of U-Boot in the past when environment was read from underlying device one character at a time. This is not the case anymore. Signed-off-by: Marek BehĂșn <marek.behun@nic.cz> Reviewed-by: Simon Glass <sjg@chromium.org>
-rw-r--r--cmd/nvedit.c30
-rw-r--r--include/env.h11
2 files changed, 15 insertions, 26 deletions
diff --git a/cmd/nvedit.c b/cmd/nvedit.c
index ddc715b..742e092 100644
--- a/cmd/nvedit.c
+++ b/cmd/nvedit.c
@@ -706,6 +706,21 @@ char *from_env(const char *envvar)
return ret;
}
+static int env_match(uchar *s1, int i2)
+{
+ if (s1 == NULL)
+ return -1;
+
+ while (*s1 == env_get_char(i2++))
+ if (*s1++ == '=')
+ return i2;
+
+ if (*s1 == '\0' && env_get_char(i2-1) == '=')
+ return i2;
+
+ return -1;
+}
+
/*
* Look up variable from environment for restricted C runtime env.
*/
@@ -816,21 +831,6 @@ static int do_env_select(struct cmd_tbl *cmdtp, int flag, int argc,
#endif /* CONFIG_SPL_BUILD */
-int env_match(uchar *s1, int i2)
-{
- if (s1 == NULL)
- return -1;
-
- while (*s1 == env_get_char(i2++))
- if (*s1++ == '=')
- return i2;
-
- if (*s1 == '\0' && env_get_char(i2-1) == '=')
- return i2;
-
- return -1;
-}
-
#ifndef CONFIG_SPL_BUILD
static int do_env_default(struct cmd_tbl *cmdtp, int flag,
int argc, char *const argv[])
diff --git a/include/env.h b/include/env.h
index b1a4003..a9b2a4c 100644
--- a/include/env.h
+++ b/include/env.h
@@ -91,17 +91,6 @@ int env_init(void);
void env_relocate(void);
/**
- * env_match() - Match a name / name=value pair
- *
- * This is used prior to relocation for finding envrionment variables
- *
- * @name: A simple 'name', or a 'name=value' pair.
- * @index: The environment index for a 'name2=value2' pair.
- * @return index for the value if the names match, else -1.
- */
-int env_match(unsigned char *name, int index);
-
-/**
* env_get() - Look up the value of an environment variable
*
* In U-Boot proper this can be called before relocation (which is when the