diff options
| author | Michal Suchanek <msuchanek@suse.de> | 2022-10-12 21:58:01 +0200 |
|---|---|---|
| committer | Simon Glass <sjg@chromium.org> | 2022-10-17 21:17:12 -0600 |
| commit | 9b7474d83b45d2b738866e9a4a46fe2b498a65d1 (patch) | |
| tree | 0a3317839b349c0fe6a31ab82cbf15fb1ab27dd0 | |
| parent | 1d0617bd747b59251782aa9f87a23e634cf543ac (diff) | |
| download | u-boot-9b7474d83b45d2b738866e9a4a46fe2b498a65d1.zip u-boot-9b7474d83b45d2b738866e9a4a46fe2b498a65d1.tar.gz u-boot-9b7474d83b45d2b738866e9a4a46fe2b498a65d1.tar.bz2 | |
dm: blk: Do not use uclass_next_device_err
blk_first_device_err/blk_next_device_err uses
uclass_first_device_err/uclass_next_device_err for device iteration.
Although the function names superficially match the return value from
uclass_first_device_err/uclass_next_device_err is never used
meaningfully, and uclass_first_device/uclass_next_device works equally
well for this purpose.
In the following patch the semantic of
uclass_first_device_err/uclass_next_device_err will be changed to be
based on uclass_first_device_check/uclass_next_device_check breaking
this sole user that uses uclass_next_device_err for iteration.
Signed-off-by: Michal Suchanek <msuchanek@suse.de>
Reviewed-by: Simon Glass <sjg@chromium.org>
| -rw-r--r-- | drivers/block/blk-uclass.c | 16 |
1 files changed, 6 insertions, 10 deletions
diff --git a/drivers/block/blk-uclass.c b/drivers/block/blk-uclass.c index 7d12d54..bcc14a6 100644 --- a/drivers/block/blk-uclass.c +++ b/drivers/block/blk-uclass.c @@ -593,11 +593,9 @@ int blk_find_next(enum blk_flag_t flags, struct udevice **devp) int blk_first_device_err(enum blk_flag_t flags, struct udevice **devp) { - int ret; - - for (ret = uclass_first_device_err(UCLASS_BLK, devp); - !ret; - ret = uclass_next_device_err(devp)) { + for (uclass_first_device(UCLASS_BLK, devp); + *devp; + uclass_next_device(devp)) { if (!blk_flags_check(*devp, flags)) return 0; } @@ -607,11 +605,9 @@ int blk_first_device_err(enum blk_flag_t flags, struct udevice **devp) int blk_next_device_err(enum blk_flag_t flags, struct udevice **devp) { - int ret; - - for (ret = uclass_next_device_err(devp); - !ret; - ret = uclass_next_device_err(devp)) { + for (uclass_next_device(devp); + *devp; + uclass_next_device(devp)) { if (!blk_flags_check(*devp, flags)) return 0; } |