diff options
author | Pali Rohár <pali@kernel.org> | 2022-01-14 18:34:43 +0100 |
---|---|---|
committer | Tom Rini <trini@konsulko.com> | 2022-03-08 07:35:53 -0500 |
commit | 1c676388b9ea3f06d538bbda42ae571fa749f9f1 (patch) | |
tree | a549d6b9f47a3571c1cecd32ead054f608e1fb9d | |
parent | 6d3c46ed0e230d999c3f20f7fd4f3a88c03b14ca (diff) | |
download | u-boot-1c676388b9ea3f06d538bbda42ae571fa749f9f1.zip u-boot-1c676388b9ea3f06d538bbda42ae571fa749f9f1.tar.gz u-boot-1c676388b9ea3f06d538bbda42ae571fa749f9f1.tar.bz2 |
tools: mkimage: Call verify_header after writing image to disk
If image backend provides verify_header callback then call it after writing
image to disk. This ensures that written image is correct.
Signed-off-by: Pali Rohár <pali@kernel.org>
Reviewed-by: Stefan Roese <sr@denx.de>
Reviewed-by: Simon Glass <sjg@chromium.org>
-rw-r--r-- | tools/mkimage.c | 41 |
1 files changed, 41 insertions, 0 deletions
diff --git a/tools/mkimage.c b/tools/mkimage.c index 74bd072..07a179a 100644 --- a/tools/mkimage.c +++ b/tools/mkimage.c @@ -340,6 +340,44 @@ static void process_args(int argc, char **argv) usage("Missing output filename"); } +static void verify_image(const struct image_type_params *tparams) +{ + struct stat sbuf; + void *ptr; + int ifd; + + ifd = open(params.imagefile, O_RDONLY | O_BINARY); + if (ifd < 0) { + fprintf(stderr, "%s: Can't open %s: %s\n", + params.cmdname, params.imagefile, + strerror(errno)); + exit(EXIT_FAILURE); + } + + if (fstat(ifd, &sbuf) < 0) { + fprintf(stderr, "%s: Can't stat %s: %s\n", + params.cmdname, params.imagefile, strerror(errno)); + exit(EXIT_FAILURE); + } + params.file_size = sbuf.st_size; + + ptr = mmap(0, params.file_size, PROT_READ, MAP_SHARED, ifd, 0); + if (ptr == MAP_FAILED) { + fprintf(stderr, "%s: Can't map %s: %s\n", + params.cmdname, params.imagefile, strerror(errno)); + exit(EXIT_FAILURE); + } + + if (tparams->verify_header((unsigned char *)ptr, params.file_size, ¶ms) != 0) { + fprintf(stderr, "%s: Failed to verify header of %s\n", + params.cmdname, params.imagefile); + exit(EXIT_FAILURE); + } + + (void)munmap(ptr, params.file_size); + (void)close(ifd); +} + int main(int argc, char **argv) { int ifd = -1; @@ -702,6 +740,9 @@ int main(int argc, char **argv) exit (EXIT_FAILURE); } + if (tparams->verify_header) + verify_image(tparams); + exit (EXIT_SUCCESS); } |