From 99343c26ac8c6e49041bd2718c8b16e5d664f8fd Mon Sep 17 00:00:00 2001 From: Gavin Shan Date: Mon, 20 Feb 2017 10:57:50 +1100 Subject: astbmc/p8dnu: Enable PCI slot's power supply on PEX9733 in hot-add path This issue is reported from superMicro's "p8dnu" platform. PEX9733 is connected to PHB direct slot. We create dynamic PCI slots for its (5) downstream ports and all of them support surprise hotplug capability. The problem is power supply lost on hot-remove and it isn't turned on automatically on hot-add. It means the PCIe link behind the slot isn't up and the PCI adapter behind the slot can't be probed successfully. This fixes the issue by forcing to turn on the power supply on hardware when user (kernel) requests to do so. Those PCI slots are identified by additional flag (PCI_SLOT_FLAG_FORCE_POWERON). Reported-by: Hank Chang Signed-off-by: Gavin Shan Tested-by: Willie Liauw Signed-off-by: Stewart Smith --- platforms/astbmc/slots.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) (limited to 'platforms') diff --git a/platforms/astbmc/slots.c b/platforms/astbmc/slots.c index aeca007..f28ad7d 100644 --- a/platforms/astbmc/slots.c +++ b/platforms/astbmc/slots.c @@ -166,6 +166,19 @@ static void create_dynamic_slot(struct phb *phb, struct pci_device *pd) slot = pcie_slot_create(phb, pd); assert(slot); init_slot_info(slot, true, NULL); + + /* On superMicro's "p8dnu" platform, we create dynamic PCI slots + * for all downstream ports of PEX9733 that is connected to PHB + * direct slot. The power supply to the PCI slot is lost after + * PCI adapter is removed from it. The power supply can't be + * turned on when the slot is in empty state. The power supply + * isn't turned on automatically when inserting PCI adapter to + * the slot at later point. We set a flag to the slot here, to + * turn on the power supply in (suprise or managed) hot-add path. + */ + if (dt_node_is_compatible(dt_root, "supermicro,p8dnu") && + slot->pd && slot->pd->vdid == 0x973310b5) + pci_slot_add_flags(slot, PCI_SLOT_FLAG_FORCE_POWERON); } void slot_table_get_slot_info(struct phb *phb, struct pci_device *pd) -- cgit v1.1