From 1a1ff0ab2c78f9257bb77301191df38242d11f0d Mon Sep 17 00:00:00 2001 From: Andrew Jeffery Date: Tue, 9 Oct 2018 00:32:33 -0700 Subject: astbmc: Remove coordinated isolation support Signed-off-by: Andrew Jeffery Signed-off-by: Stewart Smith --- platforms/astbmc/common.c | 47 ++++++----------------------------------------- 1 file changed, 6 insertions(+), 41 deletions(-) (limited to 'platforms') diff --git a/platforms/astbmc/common.c b/platforms/astbmc/common.c index f3b7e74..0cf70e2 100644 --- a/platforms/astbmc/common.c +++ b/platforms/astbmc/common.c @@ -406,23 +406,15 @@ void astbmc_early_init(void) psi_set_external_irq_policy(EXTERNAL_IRQ_POLICY_SKIBOOT); if (ast_sio_init()) { - if (!ast_can_isolate_sp()) { - /* - * BMCs claiming support for isolation must have - * correctly configured the UART and BT for host - * firmware. If not, let's apply some fixups for broken - * BMC firmwares. - */ - if (ast_io_init()) { - astbmc_fixup_uart(); - ast_setup_ibt(BT_IO_BASE, BT_LPC_IRQ); - } else - prerror("PLAT: AST IO initialisation failed!\n"); - } + if (ast_io_init()) { + astbmc_fixup_uart(); + ast_setup_ibt(BT_IO_BASE, BT_LPC_IRQ); + } else + prerror("PLAT: AST IO initialisation failed!\n"); ast_setup_sio_mbox(MBOX_IO_BASE, MBOX_LPC_IRQ); } else - prerror("PLAT: AST SIO initialisation failed!\n"); + prlog(PR_WARNING, "PLAT: AST SIO unavailable!\n"); /* Setup UART and use it as console */ uart_init(); @@ -430,35 +422,8 @@ void astbmc_early_init(void) prd_init(); } -static bool astbmc_isolate_via_io(void) -{ - return ast_sio_disable(); -} - -static bool astbmc_isolate_via_ipmi(void) -{ - return false; -} - -static void astbmc_isolate(void) -{ - bool isolated; - - isolated = ast_io_is_rw() ? astbmc_isolate_via_io() - : astbmc_isolate_via_ipmi(); - - if (!isolated) { - prlog(PR_EMERG, "PLAT: BMC isolation failed\n"); - abort(); - } - - prlog(PR_INFO, "PLAT: Isolated BMC\n"); -} - void astbmc_exit(void) { - if (ast_can_isolate_sp()) - astbmc_isolate(); ipmi_wdt_final_reset(); } -- cgit v1.1