From 13878e5b27c5916938374b9e66dd9c8d80f4dbeb Mon Sep 17 00:00:00 2001 From: Vasant Hegde Date: Mon, 7 May 2018 09:48:23 +0530 Subject: ipmi: Add BMC firmware version to device tree BMC Get device ID command gives BMC firmware version details. Lets add this to device tree. User space tools will use this information to display BMC version details. Stewart, I have added bmc information under /ibm,firmware-version node as its firmware version. But may be we should add new node (/bmc/firmware). So that we can keep BMC related information separately. Let me know your thoughts on this. Signed-off-by: Vasant Hegde Signed-off-by: Stewart Smith --- hw/ipmi/Makefile.inc | 2 +- hw/ipmi/ipmi-info.c | 112 +++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 113 insertions(+), 1 deletion(-) create mode 100644 hw/ipmi/ipmi-info.c (limited to 'hw') diff --git a/hw/ipmi/Makefile.inc b/hw/ipmi/Makefile.inc index 34d6bd3..b0af7a6 100644 --- a/hw/ipmi/Makefile.inc +++ b/hw/ipmi/Makefile.inc @@ -1,7 +1,7 @@ SUBDIRS += hw/ipmi IPMI_OBJS = ipmi-rtc.o ipmi-power.o ipmi-fru.o ipmi-sel.o -IPMI_OBJS += ipmi-watchdog.o ipmi-sensor.o ipmi-attn.o +IPMI_OBJS += ipmi-watchdog.o ipmi-sensor.o ipmi-attn.o ipmi-info.o IPMI = hw/ipmi/built-in.a $(IPMI): $(IPMI_OBJS:%=hw/ipmi/%) diff --git a/hw/ipmi/ipmi-info.c b/hw/ipmi/ipmi-info.c new file mode 100644 index 0000000..5637003 --- /dev/null +++ b/hw/ipmi/ipmi-info.c @@ -0,0 +1,112 @@ +/* Copyright 2018 IBM Corp. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or + * implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#include +#include +#include +#include +#include +#include +#include + +/* + * Respones data from IPMI Get device ID command (As defined in + * Section 20.1 Get Device ID Command - IPMI standard spec). + */ +struct ipmi_dev_id { + uint8_t dev_id; + uint8_t dev_revision; + uint8_t fw_rev1; + uint8_t fw_rev2; + uint8_t ipmi_ver; + uint8_t add_dev_support; + uint8_t manufactur_id[3]; + uint8_t product_id[2]; + uint8_t aux_fw_rev[4]; +}; +static struct ipmi_dev_id *ipmi_dev_id; + +/* Got response from BMC? */ +static bool bmc_info_waiting = false; +static bool bmc_info_valid = false; + +/* This will free ipmi_dev_id structure */ +void ipmi_dt_add_bmc_info(void) +{ + char buf[8]; + struct dt_node *dt_fw_version; + + while (bmc_info_waiting) + time_wait_ms(5); + + if (!bmc_info_valid) + return; + + dt_fw_version = dt_find_by_name(dt_root, "ibm,firmware-versions"); + if (!dt_fw_version) { + free(ipmi_dev_id); + return; + } + + memset(buf, 0, sizeof(buf)); + snprintf(buf, sizeof(buf), "%x.%02x", + ipmi_dev_id->fw_rev1, ipmi_dev_id->fw_rev2); + dt_add_property_string(dt_fw_version, "bmc-firmware-version", buf); + + free(ipmi_dev_id); +} + +static void ipmi_get_bmc_info_resp(struct ipmi_msg *msg) +{ + bmc_info_waiting = false; + + if (msg->cc != IPMI_CC_NO_ERROR) { + prlog(PR_ERR, "IPMI: IPMI_BMC_GET_DEVICE_ID cmd returned error" + " [rc : 0x%x]\n", msg->data[0]); + return; + } + + bmc_info_valid = true; + memcpy(ipmi_dev_id, msg->data, msg->resp_size); + ipmi_free_msg(msg); +} + +int ipmi_get_bmc_info_request(void) +{ + int rc; + struct ipmi_msg *msg; + + ipmi_dev_id = zalloc(sizeof(struct ipmi_dev_id)); + assert(ipmi_dev_id); + + msg = ipmi_mkmsg(IPMI_DEFAULT_INTERFACE, IPMI_BMC_GET_DEVICE_ID, + ipmi_get_bmc_info_resp, NULL, NULL, + 0, sizeof(struct ipmi_dev_id)); + if (!msg) + return OPAL_NO_MEM; + + msg->error = ipmi_get_bmc_info_resp; + prlog(PR_INFO, "IPMI: Requesting IPMI_BMC_GET_DEVICE_ID\n"); + rc = ipmi_queue_msg(msg); + if (rc) { + prlog(PR_ERR, "IPMI: Failed to queue IPMI_BMC_GET_DEVICE_ID\n"); + ipmi_free_msg(msg); + return rc; + } + + bmc_info_waiting = true; + return rc; +} -- cgit v1.1