From 9b2136247e009fd0e82a88611095654f45ab0c79 Mon Sep 17 00:00:00 2001
From: Cyril Bur <cyril.bur@au1.ibm.com>
Date: Mon, 15 Jan 2018 16:18:00 +1100
Subject: hdata/vpd: Remove possible dereference after null check (CID 207468)

The next_extry label doesn't do anything other than perform an addition
which requires a dereference of the NULL entry variable, just continue
the loop instead.

Fixes: 77190aa7 (hdata/vpd: Rework vpd node creation logic)
Signed-off-by: Cyril Bur <cyril.bur@au1.ibm.com>
Reviewed-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
---
 hdata/vpd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'hdata')

diff --git a/hdata/vpd.c b/hdata/vpd.c
index 5562579..06a3b18 100644
--- a/hdata/vpd.c
+++ b/hdata/vpd.c
@@ -402,7 +402,7 @@ void dt_init_vpd_node(void)
 		/* Get SLCA entry */
 		entry = slca_get_entry(index);
 		if (!entry)
-			goto next_entry;
+			continue;
 
 		/*
 		 * A child entry is valid if all of the following criteria is met
-- 
cgit v1.1