From ac59ecec5ca80bb4f2a8b98c3a256fccb93198d3 Mon Sep 17 00:00:00 2001 From: Balbir singh Date: Wed, 2 May 2018 20:51:39 +1000 Subject: external/mambo: simplify implementation of di We've got a great disassembly function built-in, reuse that to implement di (as in xmon). Improves 1bcd6d84: (external/mambo: Add di command to decode instructions) Signed-off-by: Balbir singh Acked-By: Michael Neuling Signed-off-by: Stewart Smith --- external/mambo/mambo_utils.tcl | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) (limited to 'external') diff --git a/external/mambo/mambo_utils.tcl b/external/mambo/mambo_utils.tcl index b503acb..ce5bccc 100644 --- a/external/mambo/mambo_utils.tcl +++ b/external/mambo/mambo_utils.tcl @@ -158,15 +158,9 @@ proc ex { ea { size 8 } } { puts "$pa : $val" } -proc di { location { count 16 } } { - set addr [expr $location & 0xfffffffffffffff0] - set top [expr $addr + ($count * 4)] - for { set i $addr } { $i < $top } { incr i 4 } { - set pc_laddr [mysim cpu 0 util itranslate $i] - set inst [mysim cpu 0 memory display $pc_laddr 4] - set disasm [mysim cpu 0 util ppc_disasm $inst $i] - puts "$pc_laddr: Enc:$inst : $disasm" - } +proc di { location { count 16 } } { + set addr [expr $location & 0xfffffffffffffff0] + disasm_mem mysim $addr $count } proc hexdump { location count } { -- cgit v1.1