From d93ddbd39b4eeac0bc11dacbdadea76df2996c13 Mon Sep 17 00:00:00 2001 From: Frederic Barrat Date: Wed, 20 Oct 2021 12:28:26 +0200 Subject: xive/p10:: Declare xive2 DT node as an interrupt-controller MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This patch fixes errors seen when linux looks for the interrupt to use for a device LSI: pci X:Y:Z of_irq_parse_pci: failed with rc=-22 The of/irq parsing code requires those new properties to be able to map the interrupt specifier correctly. It was not needed before comitting cd12ea6d8e1 ("interrupts: Do not advertise XICS support on P10"), because the LSI mapping code was defaulting to the XICS interrupt controller node, which is now removed (and had those properties). Fixes: cd12ea6d8e1 ("interrupts: Do not advertise XICS support on P10") Signed-off-by: Frederic Barrat Reviewed-by: Cédric Le Goater Signed-off-by: Vasant Hegde --- hw/xive2.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/hw/xive2.c b/hw/xive2.c index 0254175..30293cd 100644 --- a/hw/xive2.c +++ b/hw/xive2.c @@ -1955,7 +1955,12 @@ static void xive_create_mmio_dt_node(struct xive *x) tb + 3 * stride, stride); dt_add_property_strings(xive_dt_node, "compatible", - "ibm,opal-xive-pe", "ibm,opal-intc"); + "ibm,opal-xive-pe", "ibm,opal-xive-vc", + "ibm,opal-intc"); + + dt_add_property(xive_dt_node, "interrupt-controller", NULL, 0); + dt_add_property_cells(xive_dt_node, "#address-cells", 0); + dt_add_property_cells(xive_dt_node, "#interrupt-cells", 2); dt_add_property_cells(xive_dt_node, "ibm,xive-eq-sizes", 12, 16, 21, 24); -- cgit v1.1