From 88a6dc9ecc15d13d56d59da6b0d300dc03075912 Mon Sep 17 00:00:00 2001 From: Vasant Hegde Date: Mon, 19 Oct 2020 17:14:08 +0530 Subject: FSP/NVRAM: Do not assert in vNVRAM statistics call [ Upstream commit 9ca8bf1bde56330075634bd3cb601d0f6ee90514 ] `msg` is valid pointer here. I don't recall why I added assert here :-( This is not correct. We shouldn't call assert here. Also we are not using `msg`. Hence convert it to `__unused`. Fixes: 19d4f98e ('FSP/NVRAM: Handle "get vNVRAM statistics" command') Cc: skiboot-stable@lists.ozlabs.org # v5.4.x + Signed-off-by: Vasant Hegde Reviewed-by: Mahesh Salgaonkar Signed-off-by: Oliver O'Halloran Signed-off-by: Vasant Hegde --- hw/fsp/fsp-nvram.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/fsp/fsp-nvram.c b/hw/fsp/fsp-nvram.c index 80c8424..aa17cb5 100644 --- a/hw/fsp/fsp-nvram.c +++ b/hw/fsp/fsp-nvram.c @@ -305,12 +305,11 @@ static struct fsp_client fsp_nvram_client_rr = { .message = fsp_nvram_msg_rr, }; -static bool fsp_vnvram_msg(u32 cmd_sub_mod, struct fsp_msg *msg) +static bool fsp_vnvram_msg(u32 cmd_sub_mod, struct fsp_msg *msg __unused) { u32 cmd; struct fsp_msg *resp; - assert(msg == NULL); switch (cmd_sub_mod) { case FSP_CMD_GET_VNV_STATS: prlog(PR_DEBUG, -- cgit v1.1