From 736394132486d0f5fc6721379d91e7bb04b1f1e8 Mon Sep 17 00:00:00 2001 From: Vasant Hegde Date: Tue, 13 Jun 2017 13:51:49 +0530 Subject: FSP/RTC: Remove local fsp_in_reset variable Now that we are using fsp_in_rr() to detect FSP reset/reload, fsp_in_reset become redundant. Lets remove this local variable. Signed-off-by: Vasant Hegde Acked-by: Ananth N Mavinakayanahalli Signed-off-by: Stewart Smith (cherry picked from commit a34369631e6d85c26966eb0b8d5e4c44bcf96c7c) Signed-off-by: Stewart Smith --- hw/fsp/fsp-rtc.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/hw/fsp/fsp-rtc.c b/hw/fsp/fsp-rtc.c index 0a67267..cf1a56d 100644 --- a/hw/fsp/fsp-rtc.c +++ b/hw/fsp/fsp-rtc.c @@ -88,12 +88,6 @@ static enum { static bool rtc_tod_cache_dirty = false; -/* TODO We'd probably want to export and use this variable declared in fsp.c, - * instead of each component individually maintaining the state.. may be for - * later optimization - */ -static bool fsp_in_reset = false; - struct opal_tpo_data { uint64_t tpo_async_token; uint32_t *year_month_day; @@ -520,14 +514,10 @@ static bool fsp_rtc_msg_rr(u32 cmd_sub_mod, struct fsp_msg *msg) switch (cmd_sub_mod) { case FSP_RESET_START: - lock(&rtc_lock); - fsp_in_reset = true; - unlock(&rtc_lock); rc = true; break; case FSP_RELOAD_COMPLETE: lock(&rtc_lock); - fsp_in_reset = false; if (rtc_tod_cache_dirty) { rtc_flush_cached_tod(); rtc_tod_cache_dirty = false; -- cgit v1.1