From 6790a941cc05743feceab628af39d6c9c900c11e Mon Sep 17 00:00:00 2001 From: Michael Neuling Date: Wed, 9 May 2018 07:17:37 +1000 Subject: hmi: Fix clearing HMER on debug trigger In the recent patch: eddff9bf40 hmi: Clear unknown debug trigger I rebased the code from an older skiboot before the HMI rework. When I did this, I missed the handled flag. Without this the HMER is not cleared properly and the HMI keeps happening. This properly sets the handled flag and hence clears the HMER bit. Signed-off-by: Michael Neuling Reviewed-by: Mahesh Salgaonkar Signed-off-by: Stewart Smith --- core/hmi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/core/hmi.c b/core/hmi.c index 530371e..3bf20c0 100644 --- a/core/hmi.c +++ b/core/hmi.c @@ -1259,6 +1259,7 @@ static int handle_hmi_exception(uint64_t hmer, struct OpalHMIEvent *hmi_evt, } } if (hmer & SPR_HMER_TRIG_FIR_HMI) { + handled |= SPR_HMER_TRIG_FIR_HMI; hmer &= ~SPR_HMER_TRIG_FIR_HMI; hmi_print_debug("Clearing unknown debug trigger", hmer); -- cgit v1.1