From 137b05e6532371dc23dbfcf3b660dbdb060a5668 Mon Sep 17 00:00:00 2001 From: Stewart Smith Date: Wed, 10 Aug 2016 16:49:27 +1000 Subject: npu: reword "error" to indicate it's actually a warning Confirmed with Alistair on IRC, and earlier discussions with Russell. Basically, I was a bit of an idiot and didn't think hard enough before adding the FWTS annotation. Without this patch, you get spurious FirmWare Test Suite (FWTS) warnings about NVLink not working on machines that aren't fully populated with GPUs. Fixes: 00e3e275344a42f6a682be72c88c015df87a0e28 Signed-off-by: Stewart Smith (cherry picked from commit a339d4779a6a382c0e197177b0142d62e26a6416) Signed-off-by: Stewart Smith --- hw/npu.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/hw/npu.c b/hw/npu.c index 65db17f..5247f21 100644 --- a/hw/npu.c +++ b/hw/npu.c @@ -555,12 +555,7 @@ static void npu_dev_bind_pci_dev(struct npu_dev *dev) } } - /** - * @fwts-label NPUNotBound - * @fwts-advice Start debugging why we didn't find the right device. - * End result is that NVLink will not function properly - */ - prlog(PR_ERR, "%s: NPU device %04x:00:%02x.0 not binding to PCI device\n", + prlog(PR_INFO, "%s: No PCI device for NPU device %04x:00:%02x.0 to bind to. If you expect a GPU to be there, this is a problem.\n", __func__, dev->npu->phb.opal_id, dev->index); } -- cgit v1.1