diff options
| author | Mauro S. M. Rodrigues <maurosr@linux.vnet.ibm.com> | 2020-02-27 14:15:05 -0300 |
|---|---|---|
| committer | Oliver O'Halloran <oohall@gmail.com> | 2020-03-11 17:14:32 +1100 |
| commit | e4113f9400ff5366c1bcb395970306612649040b (patch) | |
| tree | 00953caabc9a96e88b184489159ba03739cd4524 /libstb | |
| parent | 82aed17a5468aff6b600ee1694a10a60f942c018 (diff) | |
| download | skiboot-e4113f9400ff5366c1bcb395970306612649040b.zip skiboot-e4113f9400ff5366c1bcb395970306612649040b.tar.gz skiboot-e4113f9400ff5366c1bcb395970306612649040b.tar.bz2 | |
tpm_i2c_nuvoton: fix tpm_read_fifo overflow check
The tpm_read_fifo expects buflen parameter which is the size of buf
parameter. Later it uses buflen to check for an overflow in the case tpm
response is bigger than buf capacity.
The check is fine, but it doesn't interrupt the code flow, so even though
we see error messages about the overflow, it doesn't prevent it.
Adding a goto after specifying the error return code fixes it.
Signed-off-by: Mauro S. M. Rodrigues <maurosr@linux.vnet.ibm.com>
Reviewed-by: Klaus Heinrich Kiwi <klausk@linux.vnet.ibm.com>
Reviewed-by: Claudio Carvalho <cclaudio@linux.ibm.com>
Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
Diffstat (limited to 'libstb')
| -rw-r--r-- | libstb/drivers/tpm_i2c_nuvoton.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/libstb/drivers/tpm_i2c_nuvoton.c b/libstb/drivers/tpm_i2c_nuvoton.c index 3679dda..d668000 100644 --- a/libstb/drivers/tpm_i2c_nuvoton.c +++ b/libstb/drivers/tpm_i2c_nuvoton.c @@ -383,6 +383,7 @@ static int tpm_read_fifo(uint8_t* buf, size_t* buflen) prlog(PR_ERR, "NUVOTON: overflow on fifo read, c=%zd, " "bc=%d, bl=%zd\n", count, burst_count, *buflen); rc = STB_TPM_OVERFLOW; + goto error; } rc = tpm_i2c_request_send(tpm_device, SMBUS_READ, |