aboutsummaryrefslogtreecommitdiff
path: root/libstb
diff options
context:
space:
mode:
authorOliver O'Halloran <oohall@gmail.com>2020-06-12 12:24:49 +1000
committerOliver O'Halloran <oohall@gmail.com>2020-06-17 21:18:45 +1000
commit028442e6573eabbc2ebc6499f92fcf5ace856553 (patch)
tree00342fd86d7d2be71d343e5b6d468aa15473e844 /libstb
parent09b4be2c46214746149f9f11f235a3ae0c6b16cc (diff)
downloadskiboot-028442e6573eabbc2ebc6499f92fcf5ace856553.zip
skiboot-028442e6573eabbc2ebc6499f92fcf5ace856553.tar.gz
skiboot-028442e6573eabbc2ebc6499f92fcf5ace856553.tar.bz2
test: Do gcov builds as a seperate pass
We only really use the gcov output when doing the coverage report as a part of the "docs" CI builds. It's useful for development to just run the unit tests so make sure the "check" and "coverage" targets are seperate. This also speeds up our CI builds since those jobs are already doing a seperate GCOV pass so building and running the GCOV binaries during the check pass is redundant. Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
Diffstat (limited to 'libstb')
-rw-r--r--libstb/secvar/test/Makefile.check6
-rw-r--r--libstb/test/Makefile.check4
2 files changed, 4 insertions, 6 deletions
diff --git a/libstb/secvar/test/Makefile.check b/libstb/secvar/test/Makefile.check
index b41eaf4..bba1197 100644
--- a/libstb/secvar/test/Makefile.check
+++ b/libstb/secvar/test/Makefile.check
@@ -8,12 +8,10 @@ SECVAR_TEST = $(patsubst %.c, %, $(wildcard $(SECVAR_TEST_DIR)/secvar-test-*.c))
HOSTCFLAGS+=-I . -I include
.PHONY : secvar-check
-secvar-check: $(SECVAR_TEST:%=%-check) $(SECVAR_TEST:%=%-gcov-run)
-secvar-check: $(SECVAR_TEST_NOSTUB:%=%-check) $(SECVAR_TEST_NOSTUB:%=%-gcov-run)
+secvar-check: $(SECVAR_TEST:%=%-check) $(SECVAR_TEST_NOSTUB:%=%-check)
.PHONY : secvar-coverage
-secvar-coverage: $(SECVAR_TEST:%=%-gcov-run)
-secvar-coverage: $(SECVAR_TEST_NOSTUB:%=%-gcov-run)
+secvar-coverage: $(SECVAR_TEST:%=%-gcov-run) $(SECVAR_TEST_NOSTUB:%=%-gcov-run)
check: secvar-check
coverage: secvar-coverage
diff --git a/libstb/test/Makefile.check b/libstb/test/Makefile.check
index d4d7cb4..6911e0a 100644
--- a/libstb/test/Makefile.check
+++ b/libstb/test/Makefile.check
@@ -9,8 +9,8 @@ libstb/test/print-stb-container-q: libstb/print-container
$(call Q, TEST , $(VALGRIND) libstb/print-container -I libstb/test/t.container |diff -u libstb/test/t.container.out -, $< t.container)
.PHONY : libstb-check
-libstb-check: $(LIBSTB_TEST:%=%-check) $(LIBSTB_TEST:%=%-gcov-run) libstb/test/print-stb-container-check
-libstb-check: $(LIBSTB_TEST_NOSTUB:%=%-check) $(LIBSTB_TEST_NOSTUB:%=%-gcov-run)
+libstb-check: $(LIBSTB_TEST:%=%-check) libstb/test/print-stb-container-check
+libstb-check: $(LIBSTB_TEST_NOSTUB:%=%-check)
.PHONY : libstb-coverage
libstb-coverage: $(LIBSTB_TEST:%=%-gcov-run)