aboutsummaryrefslogtreecommitdiff
path: root/libflash/test/test-flash.c
diff options
context:
space:
mode:
authorCyril Bur <cyril.bur@au1.ibm.com>2015-08-26 16:02:32 +1000
committerStewart Smith <stewart@linux.vnet.ibm.com>2015-08-28 15:24:04 +1000
commit315acaa5d6a271d2dd6516a358a38c51c10667fa (patch)
tree6c8126f2493804c7983ec3b339cca73d9e5ee4c1 /libflash/test/test-flash.c
parent123441e17fc5a9a40e45fde5ecc8209e5c0ad0cc (diff)
downloadskiboot-315acaa5d6a271d2dd6516a358a38c51c10667fa.zip
skiboot-315acaa5d6a271d2dd6516a358a38c51c10667fa.tar.gz
skiboot-315acaa5d6a271d2dd6516a358a38c51c10667fa.tar.bz2
libflash: Return a pointer to internal structure.
There are some functions (notably: erase_chip and set_4b_mode) which cannot be abstracted away by the blocklevel interface, this means that if they are really needed (by pflash for example) then at the moment a program like pflash would need to pass a blocklevel_device struct to libflash. This forces libflash to trust that it was given a blocklevel that it did init. If it didn't init it the container_of call will return junk and libflash has no way to protect its self. This method (while very useful) has destroyed type safety. As such, this commit reintroduces some typesafety back into this stack. Signed-off-by: Cyril Bur <cyril.bur@au1.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Diffstat (limited to 'libflash/test/test-flash.c')
-rw-r--r--libflash/test/test-flash.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/libflash/test/test-flash.c b/libflash/test/test-flash.c
index cf2b3a5..c93aef5 100644
--- a/libflash/test/test-flash.c
+++ b/libflash/test/test-flash.c
@@ -378,7 +378,7 @@ int main(void)
memset(sim_image, 0xff, sim_image_sz);
test = malloc(0x10000 * 2);
- rc = flash_init(&sim_ctrl, &bl);
+ rc = flash_init(&sim_ctrl, &bl, NULL);
if (rc) {
ERR("flash_init failed with err %d\n", rc);
exit(1);