aboutsummaryrefslogtreecommitdiff
path: root/libc/test
diff options
context:
space:
mode:
authorDaniel Axtens <dja@axtens.net>2015-02-20 13:45:06 +1100
committerStewart Smith <stewart@linux.vnet.ibm.com>2015-02-23 13:35:50 +1100
commite4f5a453bb4e8b9ee3820c0f495beff417a867de (patch)
tree0aa2796bbd84b9f1b640e0a0f01e6f1a24c36afa /libc/test
parente4ce915ea0631f5b17082aa8c70079b0e9dc33af (diff)
downloadskiboot-e4f5a453bb4e8b9ee3820c0f495beff417a867de.zip
skiboot-e4f5a453bb4e8b9ee3820c0f495beff417a867de.tar.gz
skiboot-e4f5a453bb4e8b9ee3820c0f495beff417a867de.tar.bz2
Don't recognise a double hex prefix (0x0xNN) as valid.
When autodetecting the base, the code would strip hex prefixes twice. Now the string is not modified in the detection stage. Signed-off-by: Daniel Axtens <dja@axtens.net> Reviewed-by: Cyril Bur <cyrilbur@gmail.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Diffstat (limited to 'libc/test')
-rw-r--r--libc/test/run-stdlib.c7
1 files changed, 3 insertions, 4 deletions
diff --git a/libc/test/run-stdlib.c b/libc/test/run-stdlib.c
index bb64790..98c79b7 100644
--- a/libc/test/run-stdlib.c
+++ b/libc/test/run-stdlib.c
@@ -41,8 +41,8 @@ int main(void)
/* our atoi recognises hex! */
assert(atoi("0x800") == 0x800);
- /* Really weird hex! */
- assert(atoi("0x0x800") == 0x800);
+ /* But not with a duplicate prefix */
+ assert(atoi("0x0x800") == 0);
/* atol - ensure it recognises longs */
assert(atol("2147483648") == 2147483648);
@@ -73,8 +73,7 @@ int main(void)
/* strtoul - autodetection of base */
assert(strtoul(" 123456", NULL, 0) == 123456);
assert(strtoul("0x800", NULL, 0) == 0x800);
- /* Again, really weird hex */
- assert(strtoul("0x0x800", NULL, 0) == 0x800);
+ assert(strtoul("0x0x800", NULL, 0) == 0);
/* strtoul - weird/invalid bases */
assert(strtoul("z", NULL, -1) == 0);