diff options
| author | Nicholas Piggin <npiggin@gmail.com> | 2018-02-02 15:46:24 +1000 |
|---|---|---|
| committer | Stewart Smith <stewart@linux.vnet.ibm.com> | 2018-02-08 18:21:42 -0600 |
| commit | d2cc3957abef48f3afdf8ec61d69e87e3446d562 (patch) | |
| tree | 5636662ffddd64e4a6fd45056a36ef6cf6e5e83f /include/pci.h | |
| parent | e88bb694d32e909960b1ae6f717265cc0aba8e4d (diff) | |
| download | skiboot-d2cc3957abef48f3afdf8ec61d69e87e3446d562.zip skiboot-d2cc3957abef48f3afdf8ec61d69e87e3446d562.tar.gz skiboot-d2cc3957abef48f3afdf8ec61d69e87e3446d562.tar.bz2 | |
fast-reboot: move pci_reset error handling into fast-reboot code
pci_reset() currently does a platform reboot if it fails. It
should not know about fast-reboot at this level, so instead have
it return an error, and the fast reboot caller will do the
platform reboot.
The code essentially does the same thing, but flexibility is
improved. Ideally the fast reboot code should perform pci_reset
and all such fail-able operations before the CPU resets itself
and destroys its own stack. That's not the case now, but that
should be the goal.
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
Acked-by: Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Diffstat (limited to 'include/pci.h')
| -rw-r--r-- | include/pci.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/pci.h b/include/pci.h index c085b6b..508ebf4 100644 --- a/include/pci.h +++ b/include/pci.h @@ -475,7 +475,7 @@ extern void pci_std_swizzle_irq_map(struct dt_node *dt_node, /* Initialize all PCI slots */ extern void pci_init_slots(void); -extern void pci_reset(void); +extern int64_t pci_reset(void); extern void opal_pci_eeh_set_evt(uint64_t phb_id); extern void opal_pci_eeh_clear_evt(uint64_t phb_id); |