aboutsummaryrefslogtreecommitdiff
path: root/hw
diff options
context:
space:
mode:
authorNicholas Piggin <npiggin@gmail.com>2019-12-08 22:23:11 +1000
committerOliver O'Halloran <oohall@gmail.com>2019-12-16 14:50:56 +1100
commite04a34af200a31a29d83162a46dedbeb59ae917e (patch)
tree8af57c0447671bc273c0ffc792e09161163e4008 /hw
parent5178691d0ad8d684f061d596dc6e025823fc0fec (diff)
downloadskiboot-e04a34af200a31a29d83162a46dedbeb59ae917e.zip
skiboot-e04a34af200a31a29d83162a46dedbeb59ae917e.tar.gz
skiboot-e04a34af200a31a29d83162a46dedbeb59ae917e.tar.bz2
fix simple sparse warnings
Should be no real code change, these mostly update type declarations that sparse complains about. Signed-off-by: Nicholas Piggin <npiggin@gmail.com> Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
Diffstat (limited to 'hw')
-rw-r--r--hw/fsp/fsp-dpo.c2
-rw-r--r--hw/imc.c4
-rw-r--r--hw/vas.c2
3 files changed, 4 insertions, 4 deletions
diff --git a/hw/fsp/fsp-dpo.c b/hw/fsp/fsp-dpo.c
index 8f0861e..da83a93 100644
--- a/hw/fsp/fsp-dpo.c
+++ b/hw/fsp/fsp-dpo.c
@@ -18,7 +18,7 @@
#define DPO_CMD_SGN_BYTE1 0x20 /* Byte[1] signature */
#define DPO_TIMEOUT 2700 /* 45 minutes in seconds */
-bool fsp_dpo_pending;
+static bool fsp_dpo_pending;
static unsigned long fsp_dpo_init_tb;
/*
diff --git a/hw/imc.c b/hw/imc.c
index 36c2cf3..3a5382c 100644
--- a/hw/imc.c
+++ b/hw/imc.c
@@ -455,8 +455,8 @@ static void imc_dt_update_nest_node(struct dt_node *dev)
const struct dt_property *type;
/* Add the base_addr and chip-id properties for the nest node */
- base_addr = malloc(sizeof(uint64_t) * nr_chip);
- chipids = malloc(sizeof(uint32_t) * nr_chip);
+ base_addr = malloc(sizeof(u64) * nr_chip);
+ chipids = malloc(sizeof(u32) * nr_chip);
for_each_chip(chip) {
base_addr[i] = cpu_to_be64(chip->homer_base);
chipids[i] = cpu_to_be32(chip->id);
diff --git a/hw/vas.c b/hw/vas.c
index b4af31d..aebfebd 100644
--- a/hw/vas.c
+++ b/hw/vas.c
@@ -494,7 +494,7 @@ static int init_vas_inst(struct dt_node *np, bool enable)
}
-void vas_init()
+void vas_init(void)
{
bool enabled;
struct dt_node *np;