aboutsummaryrefslogtreecommitdiff
path: root/hw
diff options
context:
space:
mode:
authorStewart Smith <stewart@linux.vnet.ibm.com>2015-06-18 15:28:42 +1000
committerStewart Smith <stewart@linux.vnet.ibm.com>2015-06-18 15:28:42 +1000
commitb3c88d9cd5e386a4c05ae650c0bf837bc1cbf4b4 (patch)
treed2da4b6f62ed147281ed867f61220e6775068816 /hw
parent249db78b046b912c4fd94dfc0c62a47ad5ab45aa (diff)
parent092d2a8e58cad4c9cac3dc573f5af6409d2d1ce6 (diff)
downloadskiboot-b3c88d9cd5e386a4c05ae650c0bf837bc1cbf4b4.zip
skiboot-b3c88d9cd5e386a4c05ae650c0bf837bc1cbf4b4.tar.gz
skiboot-b3c88d9cd5e386a4c05ae650c0bf837bc1cbf4b4.tar.bz2
Merge branch 'stable'
Diffstat (limited to 'hw')
-rw-r--r--hw/bt.c9
-rw-r--r--hw/ipmi/ipmi-sel.c6
2 files changed, 8 insertions, 7 deletions
diff --git a/hw/bt.c b/hw/bt.c
index 8a9e935..da59b14 100644
--- a/hw/bt.c
+++ b/hw/bt.c
@@ -207,7 +207,7 @@ static void bt_flush_msg(void)
static void bt_get_resp(void)
{
int i;
- struct bt_msg *bt_msg;
+ struct bt_msg *tmp_bt_msg, *bt_msg = NULL;
struct ipmi_msg *ipmi_msg;
uint8_t resp_len, netfn, seq, cmd;
uint8_t cc = IPMI_CC_NO_ERROR;
@@ -236,13 +236,14 @@ static void bt_get_resp(void)
cc = bt_inb(BT_HOST2BMC);
/* Find the corresponding messasge */
- list_for_each(&bt.msgq, bt_msg, link) {
- if (bt_msg->seq == seq) {
+ list_for_each(&bt.msgq, tmp_bt_msg, link) {
+ if (tmp_bt_msg->seq == seq) {
+ bt_msg = tmp_bt_msg;
break;
}
}
- if (!bt_msg || (bt_msg->seq != seq)) {
+ if (!bt_msg) {
/* A response to a message we no longer care about. */
prlog(PR_INFO, "BT: Nobody cared about a response to an BT/IPMI message\n");
bt_flush_msg();
diff --git a/hw/ipmi/ipmi-sel.c b/hw/ipmi/ipmi-sel.c
index 8851dc3..7007f83 100644
--- a/hw/ipmi/ipmi-sel.c
+++ b/hw/ipmi/ipmi-sel.c
@@ -69,10 +69,10 @@ static void ipmi_elog_error(struct ipmi_msg *msg)
if (msg->cc == IPMI_LOST_ARBITRATION_ERR)
/* Retry due to SEL erase */
ipmi_queue_msg(msg);
- else
+ else {
opal_elog_complete(msg->user_data, false);
-
- ipmi_free_msg(msg);
+ ipmi_free_msg(msg);
+ }
}
/* Goes through the required steps to add a complete eSEL: