diff options
| author | Michael Neuling <mikey@neuling.org> | 2017-07-20 16:22:18 +1000 |
|---|---|---|
| committer | Stewart Smith <stewart@linux.vnet.ibm.com> | 2017-07-25 15:42:30 +1000 |
| commit | 86b2abaff8d975e4e42085c278b845a63d81e349 (patch) | |
| tree | 5c058e82363b69a721da727738eb42197396ea9b /hw | |
| parent | 61129e82527f7a960756e3f9a9d5701d9e7623c8 (diff) | |
| download | skiboot-86b2abaff8d975e4e42085c278b845a63d81e349.zip skiboot-86b2abaff8d975e4e42085c278b845a63d81e349.tar.gz skiboot-86b2abaff8d975e4e42085c278b845a63d81e349.tar.bz2 | |
phb4: Remove retry on electrical link timeout
Currently we retry if we don't detect an electrical link. This is
pointless as all devices should respond in the given time.
This patches removes this retry and just returns OPAL_HARDWARE if we
don't detect an electrical link.
This has the additional benefit of improving boot times on machines
that have badly wired presence detect (ie. says a device is present
when there isn't).
Signed-off-by: Michael Neuling <mikey@neuling.org>
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Diffstat (limited to 'hw')
| -rw-r--r-- | hw/phb4.c | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -2219,7 +2219,7 @@ static int64_t phb4_poll_link(struct pci_slot *slot) if (slot->retries-- == 0) { PHBERR(p, "LINK: Timeout waiting for electrical link\n"); PHBDBG(p, "LINK: DLP train control: 0x%016llx\n", reg); - return phb4_retry_state(slot); + return OPAL_HARDWARE; } return pci_slot_set_sm_timeout(slot, msecs_to_tb(100)); case PHB4_SLOT_LINK_WAIT: |