diff options
| author | Stewart Smith <stewart@linux.ibm.com> | 2019-05-20 14:45:32 +1000 |
|---|---|---|
| committer | Stewart Smith <stewart@linux.ibm.com> | 2019-05-21 09:49:32 +1000 |
| commit | 59bdc3a2d199a0d2599732e9ff05f4efb4213c10 (patch) | |
| tree | a2fde7c6f9a5eca01e78ad1446a2b597db15da36 /hw | |
| parent | e0ed7e9985b49a3c9a2eac4c713aee1d441d5f47 (diff) | |
| download | skiboot-59bdc3a2d199a0d2599732e9ff05f4efb4213c10.zip skiboot-59bdc3a2d199a0d2599732e9ff05f4efb4213c10.tar.gz skiboot-59bdc3a2d199a0d2599732e9ff05f4efb4213c10.tar.bz2 | |
hw/xive.c: Fix memcmp() in DEBUG build to compare struct not ptr
With GCC9:
hw/xive.c: In function ‘xive_check_eq_update’:
hw/xive.c:3034:29: error: argument to ‘sizeof’ in ‘__builtin_memcmp’ call is the same expression as the first source; did you mean to dereference it? [-Werror=sizeof-pointer-memaccess]
if (memcmp(eq, &eq2, sizeof(eq)) != 0) {
^
hw/xive.c: In function ‘xive_check_vpc_update’:
hw/xive.c:3056:29: error: argument to ‘sizeof’ in ‘__builtin_memcmp’ call is the same expression as the first source; did you mean to dereference it? [-Werror=sizeof-pointer-memaccess]
if (memcmp(vp, &vp2, sizeof(vp)) != 0) {
^
cc1: all warnings being treated as errors
Fixes: 2eea386767728
Signed-off-by: Stewart Smith <stewart@linux.ibm.com>
Diffstat (limited to 'hw')
| -rw-r--r-- | hw/xive.c | 4 |
1 files changed, 2 insertions, 2 deletions
@@ -3027,7 +3027,7 @@ static bool xive_check_eq_update(struct xive *x, uint32_t idx, struct xive_eq *e assert(eq_p); eq2 = *eq_p; - if (memcmp(eq, &eq2, sizeof(eq)) != 0) { + if (memcmp(eq, &eq2, sizeof(struct xive_eq)) != 0) { xive_err(x, "EQ update mismatch idx %d\n", idx); xive_err(x, "want: %08x %08x %08x %08x\n", eq->w0, eq->w1, eq->w2, eq->w3); @@ -3049,7 +3049,7 @@ static bool xive_check_vpc_update(struct xive *x, uint32_t idx, struct xive_vp * assert(vp_p); vp2 = *vp_p; - if (memcmp(vp, &vp2, sizeof(vp)) != 0) { + if (memcmp(vp, &vp2, sizeof(struct xive_vp)) != 0) { xive_err(x, "VP update mismatch idx %d\n", idx); xive_err(x, "want: %08x %08x %08x %08x\n", vp->w0, vp->w1, vp->w2, vp->w3); |