diff options
| author | Balbir singh <bsingharora@gmail.com> | 2018-05-18 09:31:01 +1000 |
|---|---|---|
| committer | Stewart Smith <stewart@linux.ibm.com> | 2018-05-24 04:03:19 -0500 |
| commit | e18f3fd2301cbc7b02a2cb84da4afaff69ff1e97 (patch) | |
| tree | fe2fe3d7b00b185b6ecdf9d53697d1dd2aed69fa /hw | |
| parent | ad58f8da1d4fbd45abf163514a9643a14e1636ee (diff) | |
| download | skiboot-e18f3fd2301cbc7b02a2cb84da4afaff69ff1e97.zip skiboot-e18f3fd2301cbc7b02a2cb84da4afaff69ff1e97.tar.gz skiboot-e18f3fd2301cbc7b02a2cb84da4afaff69ff1e97.tar.bz2 | |
check for NULL input string in is_sai_loc_code
Caught by scan-build, also constant-ify the input
parameter.
Signed-off-by: Balbir singh <bsingharora@gmail.com>
Reviewed-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
Signed-off-by: Stewart Smith <stewart@linux.ibm.com>
Diffstat (limited to 'hw')
| -rw-r--r-- | hw/fsp/fsp-leds.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/hw/fsp/fsp-leds.c b/hw/fsp/fsp-leds.c index 0fe0309..9040c0a 100644 --- a/hw/fsp/fsp-leds.c +++ b/hw/fsp/fsp-leds.c @@ -203,9 +203,12 @@ static inline void opal_led_update_complete(u64 async_token, u64 result) opal_queue_msg(OPAL_MSG_ASYNC_COMP, NULL, NULL, async_token, result); } -static inline bool is_sai_loc_code(char *loc_code) +static inline bool is_sai_loc_code(const char *loc_code) { - if (!strcmp(sai_data.loc_code, loc_code)) + if (!loc_code) + return false; + + if (!strncmp(sai_data.loc_code, loc_code, strlen(sai_data.loc_code))) return true; return false; |