diff options
| author | Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> | 2015-07-01 10:34:27 +0530 |
|---|---|---|
| committer | Stewart Smith <stewart@linux.vnet.ibm.com> | 2015-08-13 17:15:01 +1000 |
| commit | d3e4c0cb7f217fe49d90aadaf22171d39a85b53d (patch) | |
| tree | 0d25dbb4d0aef5279da54dfaf0224b8ded2603e8 /hw | |
| parent | 4f689d964edb0cba34e5fff038f5ec4c184e0249 (diff) | |
| download | skiboot-d3e4c0cb7f217fe49d90aadaf22171d39a85b53d.zip skiboot-d3e4c0cb7f217fe49d90aadaf22171d39a85b53d.tar.gz skiboot-d3e4c0cb7f217fe49d90aadaf22171d39a85b53d.tar.bz2 | |
hw/p7ioc-phb.c: Fix assignment of addr
In p7ioc_err_inject_io32() addr is passed as an argument.
Based on its value , we have a conditional check(s).
Re-assigning the addr to 0x0ull, make the whole branching
check(s) a dead code.
Remove the re-assignment of addr, to fix the issue.
Fixes Coverity defect#101020.
Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Cc: Gavin Shan <gwshan@linux.vnet.ibm.com>
Acked-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Diffstat (limited to 'hw')
| -rw-r--r-- | hw/p7ioc-phb.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/hw/p7ioc-phb.c b/hw/p7ioc-phb.c index 0b37993..5167832 100644 --- a/hw/p7ioc-phb.c +++ b/hw/p7ioc-phb.c @@ -1409,7 +1409,6 @@ static int64_t p7ioc_err_inject_io32(struct p7ioc_phb *p, uint32_t pe_no, int32_t index; a = 0x0ull; - addr = 0x0ull; prefer = 0x0ull; for (index = 0; index < 128; index++) { if (GETFIELD(IODA_XXDT_PE, p->iod_cache[index]) != pe_no) |