aboutsummaryrefslogtreecommitdiff
path: root/hw
diff options
context:
space:
mode:
authorStewart Smith <stewart@linux.vnet.ibm.com>2015-08-31 17:52:24 +1000
committerStewart Smith <stewart@linux.vnet.ibm.com>2015-08-31 17:52:24 +1000
commit13c603d6a14ba06027a9b178c9d26b3e691b45c2 (patch)
treed21d4c232e3de412b1bf073a1182f5ed5381899c /hw
parentc932d0c3b641072afd2a20db29b133768d1afa81 (diff)
downloadskiboot-13c603d6a14ba06027a9b178c9d26b3e691b45c2.zip
skiboot-13c603d6a14ba06027a9b178c9d26b3e691b45c2.tar.gz
skiboot-13c603d6a14ba06027a9b178c9d26b3e691b45c2.tar.bz2
Fix stored value never read warning from scan-build in FSP code update
Instead just print a PR_TRACE notice as (by design), this is an okay thing. Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Diffstat (limited to 'hw')
-rw-r--r--hw/fsp/fsp-codeupdate.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/hw/fsp/fsp-codeupdate.c b/hw/fsp/fsp-codeupdate.c
index bda7222..f6293a0 100644
--- a/hw/fsp/fsp-codeupdate.c
+++ b/hw/fsp/fsp-codeupdate.c
@@ -1041,6 +1041,9 @@ static int fsp_flash_firmware(void)
*/
rc = code_update_del_lid(DEL_UPD_SIDE_LIDS);
+ if (rc)
+ prlog(PR_TRACE, "CUPD: Failed to delete LIDs (%d). This is okay, continuing..", rc);
+
for (i = 0; i < be16_to_cpu(header->number_lids); i++) {
if (be32_to_cpu(idx_entry->size) > LID_MAX_SIZE) {
log_simple_error(&e_info(OPAL_RC_CU_FLASH), "CUPD: LID"