diff options
| author | Benjamin Herrenschmidt <benh@kernel.crashing.org> | 2017-11-21 20:32:29 +1100 |
|---|---|---|
| committer | Stewart Smith <stewart@linux.vnet.ibm.com> | 2017-11-28 20:39:07 -0600 |
| commit | 7d385d1b942c6080d05548d2ab319e7af640f735 (patch) | |
| tree | 0d2cc88a4e1081dceea618f798c5aa74403c857b /hw | |
| parent | 6b1cc437315d81267597756a78777da8001e2d04 (diff) | |
| download | skiboot-7d385d1b942c6080d05548d2ab319e7af640f735.zip skiboot-7d385d1b942c6080d05548d2ab319e7af640f735.tar.gz skiboot-7d385d1b942c6080d05548d2ab319e7af640f735.tar.bz2 | |
xive: Warn on valid VPs found in abnormal cases
If an allocated VP is left valid at xive_reset() or Linux tries
to free a valid (enabled) VP block, print errors. The former happens
occasionally if kdump'ing while KVM is running so keep it as a debug
message. The latter is a programming error in Linux so use a an
error log level.
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Diffstat (limited to 'hw')
| -rw-r--r-- | hw/xive.c | 5 |
1 files changed, 4 insertions, 1 deletions
@@ -4539,6 +4539,7 @@ static void xive_reset_one(struct xive *x) continue; /* Clear it */ + xive_dbg(x, "VP 0x%x:0x%x is valid at reset\n", x->block_id, i); xive_vpc_cache_update(x, x->block_id, i, 0, 8, &vp0, false, true); } @@ -4698,8 +4699,10 @@ static int64_t opal_xive_free_vp_block(uint64_t vp_base) } /* VP must be disabled */ - if (vp->w0 & VP_W0_VALID) + if (vp->w0 & VP_W0_VALID) { + prlog(PR_ERR, "XIVE: freeing active VP %d\n", vp_id); return OPAL_XIVE_FREE_ACTIVE; + } /* Not populated */ if (vp->w1 == 0) |