diff options
| author | Vasant Hegde <hegdevasant@linux.vnet.ibm.com> | 2017-10-05 16:39:26 +0530 |
|---|---|---|
| committer | Stewart Smith <stewart@linux.vnet.ibm.com> | 2017-10-10 13:36:17 +1100 |
| commit | a1fcbaac29d785875eaea09bd70e9a287580a452 (patch) | |
| tree | e6edcedd397ef2cd5de4a3101ad15c0b3adf51e0 /hw | |
| parent | 36274947321306e4e6c076092509ff023c113b2e (diff) | |
| download | skiboot-a1fcbaac29d785875eaea09bd70e9a287580a452.zip skiboot-a1fcbaac29d785875eaea09bd70e9a287580a452.tar.gz skiboot-a1fcbaac29d785875eaea09bd70e9a287580a452.tar.bz2 | |
xscom: Do not print error message for 'chiplet offline' return values
xscom_read/write operations returns CHIPLET_OFFLINE when chiplet is offline.
Some multicast xscom_read/write requests from HBRT results in xscom operation
on offline chiplet(s) and printing below warnings in OPAL console.
[ 135.036327572,3] XSCOM: Read failed, ret = -14
[ 135.092689829,3] XSCOM: Read failed, ret = -14
This results in unnecessary bugs. Hence remove error message for multicast
SCOM operations.
Suggested-by: Daniel M Crowell <dcrowell@us.ibm.com>
Tested-by: Pridhiviraj Paidipeddi <ppaidipe@linux.vnet.ibm.com>
Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
Reviewed-by: Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Diffstat (limited to 'hw')
| -rw-r--r-- | hw/xscom.c | 14 |
1 files changed, 14 insertions, 0 deletions
@@ -238,6 +238,12 @@ static bool xscom_gcid_ok(uint32_t gcid) return get_chip(gcid) != NULL; } +/* Determine if SCOM address is multicast */ +static inline bool xscom_is_multicast_addr(uint32_t addr) +{ + return (((addr >> 30) & 0x1) == 0x1); +} + /* * Low level XSCOM access functions, perform a single direct xscom * access via MMIO @@ -274,6 +280,10 @@ static int __xscom_read(uint32_t gcid, uint32_t pcb_addr, uint64_t *val) break; } + /* Do not print error message for multicast SCOMS */ + if (xscom_is_multicast_addr(pcb_addr) && ret == OPAL_XSCOM_CHIPLET_OFF) + return ret; + prerror("XSCOM: Read failed, ret = %lld\n", ret); return ret; } @@ -310,6 +320,10 @@ static int __xscom_write(uint32_t gcid, uint32_t pcb_addr, uint64_t val) break; } + /* Do not print error message for multicast SCOMS */ + if (xscom_is_multicast_addr(pcb_addr) && ret == OPAL_XSCOM_CHIPLET_OFF) + return ret; + prerror("XSCOM: Write failed, ret = %lld\n", ret); return ret; } |