aboutsummaryrefslogtreecommitdiff
path: root/hw
diff options
context:
space:
mode:
authorMichael Neuling <mikey@neuling.org>2017-07-12 12:06:47 +1000
committerStewart Smith <stewart@linux.vnet.ibm.com>2017-07-13 10:19:45 +1000
commit888524d02653bb79707348e13210526dea924985 (patch)
treed83357a1ae920ccfaad0018c53678a90d248029f /hw
parent5991fd6ee87caf775ebcbf60003892daa76b5fb7 (diff)
downloadskiboot-888524d02653bb79707348e13210526dea924985.zip
skiboot-888524d02653bb79707348e13210526dea924985.tar.gz
skiboot-888524d02653bb79707348e13210526dea924985.tar.bz2
phb4: Remove incorrect state transition
When waiting in PHB4_SLOT_CRESET_WAIT_CQ for transations to end, we incorrectly move onto the next state. Generally we don't hit this as the transactions have ended already anyway. This removes the incorrect state transition. Signed-off-by: Michael Neuling <mikey@neuling.org> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Diffstat (limited to 'hw')
-rw-r--r--hw/phb4.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/hw/phb4.c b/hw/phb4.c
index 1d10bb8..088ca96 100644
--- a/hw/phb4.c
+++ b/hw/phb4.c
@@ -2455,7 +2455,6 @@ static int64_t phb4_creset(struct pci_slot *slot)
PHBERR(p, "Timeout waiting for pending transaction\n");
goto error;
}
- pci_slot_set_state(slot, PHB4_SLOT_CRESET_REINIT);
return pci_slot_set_sm_timeout(slot, msecs_to_tb(100));
case PHB4_SLOT_CRESET_REINIT:
PHBDBG(p, "CRESET: Reinitialization\n");