aboutsummaryrefslogtreecommitdiff
path: root/hw
diff options
context:
space:
mode:
authorStewart Smith <stewart@linux.vnet.ibm.com>2015-08-31 17:48:46 +1000
committerStewart Smith <stewart@linux.vnet.ibm.com>2015-08-31 17:48:46 +1000
commitc932d0c3b641072afd2a20db29b133768d1afa81 (patch)
treeb18eba2d2b568f19cecb1b6c7702d4fc51ce208b /hw
parenta0a677beeaaea087d855b8226062fd96f3135a5e (diff)
downloadskiboot-c932d0c3b641072afd2a20db29b133768d1afa81.zip
skiboot-c932d0c3b641072afd2a20db29b133768d1afa81.tar.gz
skiboot-c932d0c3b641072afd2a20db29b133768d1afa81.tar.bz2
Fix scan-build waring of never read rc value
Just log an error if we fail to re-read GP0. Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Diffstat (limited to 'hw')
-rw-r--r--hw/slw.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/hw/slw.c b/hw/slw.c
index a097b20..9aec41c 100644
--- a/hw/slw.c
+++ b/hw/slw.c
@@ -203,6 +203,10 @@ static bool slw_general_init(struct proc_chip *chip, struct cpu_thread *c)
/* Read back for debug */
rc = xscom_read(chip->id, XSCOM_ADDR_P8_EX_SLAVE(core, EX_PM_GP0), &tmp);
+ if (rc)
+ log_simple_error(&e_info(OPAL_RC_SLW_INIT),
+ "SLW: Failed to re-read PM_GP0. Continuing...\n");
+
prlog(PR_TRACE, "SLW: PMGP0 read 0x%016llx\n", tmp);