diff options
| author | Benjamin Herrenschmidt <benh@kernel.crashing.org> | 2015-09-30 15:47:01 +1000 |
|---|---|---|
| committer | Stewart Smith <stewart@linux.vnet.ibm.com> | 2015-09-30 21:55:52 +1000 |
| commit | 902e1a67c3a245c7cd52d8bf6a53fdafe13afd6e (patch) | |
| tree | a602cf0fa0644d34f4378e9f2849cfec6f876247 /hw/xscom.c | |
| parent | 457bcd7a67c67bf477b198d7f06d2a9919b9f189 (diff) | |
| download | skiboot-902e1a67c3a245c7cd52d8bf6a53fdafe13afd6e.zip skiboot-902e1a67c3a245c7cd52d8bf6a53fdafe13afd6e.tar.gz skiboot-902e1a67c3a245c7cd52d8bf6a53fdafe13afd6e.tar.bz2 | |
xscom: Fix logging of indirect XSCOM errors
We didn't pass the right "is_write" argument for writes and
the string used for logging was somewhat confusing.
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Diffstat (limited to 'hw/xscom.c')
| -rw-r--r-- | hw/xscom.c | 6 |
1 files changed, 3 insertions, 3 deletions
@@ -165,12 +165,12 @@ static void xscom_handle_ind_error(uint64_t data, uint32_t gcid, /* XXX: Create error log entry ? */ if (timeout) log_simple_error(&e_info(OPAL_RC_XSCOM_INDIRECT_RW), - "XSCOM: %s indirect timeout, gcid=0x%x pcb_addr=0x%llx" + "XSCOM: indirect %s timeout, gcid=0x%x pcb_addr=0x%llx" " stat=0x%x\n", is_write ? "write" : "read", gcid, pcb_addr, stat); else log_simple_error(&e_info(OPAL_RC_XSCOM_INDIRECT_RW), - "XSCOM: %s indirect error, gcid=0x%x pcb_addr=0x%llx" + "XSCOM: indirect %s error, gcid=0x%x pcb_addr=0x%llx" " stat=0x%x\n", is_write ? "write" : "read", gcid, pcb_addr, stat); } @@ -323,7 +323,7 @@ static int xscom_indirect_write(uint32_t gcid, uint64_t pcb_addr, uint64_t val) if ((data & XSCOM_DATA_IND_COMPLETE) || (retries >= XSCOM_IND_MAX_RETRIES)) { xscom_handle_ind_error(data, gcid, pcb_addr, - false); + true); rc = OPAL_HARDWARE; goto bail; } |