Fix possible return garbage from xscom_read_cfam_chipid()

If we get an error from the xscom_read() call we could extract a
garbage chip_id rather than just returning an error.

Caught by LLVM scan-build

Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>

1 files changed, 2 insertions, 1 deletions

diff --git a/hw/xscom.c b/hw/xscom.c
index c023a9d..9d3523c 100644
--- a/hw/xscom.c
+++ b/hw/xscom.c
@@ -433,7 +433,8 @@ int64_t xscom_read_cfam_chipid(uint32_t partid, uint32_t *chip_id)
 		rc = xscom_read(partid, 0xf000f, &val);
 
 	/* Extract CFAM id */
-	*chip_id = (uint32_t)(val >> 44);
+	if (rc == OPAL_SUCCESS)
+		*chip_id = (uint32_t)(val >> 44);
 
 	return rc;
 }