diff options
| author | Cédric Le Goater <clg@kaod.org> | 2018-04-03 08:57:23 +0200 |
|---|---|---|
| committer | Stewart Smith <stewart@linux.vnet.ibm.com> | 2018-04-03 03:30:46 -0500 |
| commit | 19335bbf77d85bcaf74c037efef9f0e7e76cf227 (patch) | |
| tree | b3392817721d2b497757b6bff75c5bb3660ed593 /hw/xive.c | |
| parent | 6bfe04890f094bf38824fc3e445a4fee7aa6bece (diff) | |
| download | skiboot-19335bbf77d85bcaf74c037efef9f0e7e76cf227.zip skiboot-19335bbf77d85bcaf74c037efef9f0e7e76cf227.tar.gz skiboot-19335bbf77d85bcaf74c037efef9f0e7e76cf227.tar.bz2 | |
xive: disable store EOI support
Hardware has limitations which would require to put a sync after each
store EOI to make sure the MMIO operations that change the ESB state
are ordered. This is a killer for performance and the PHBs do not
support the sync. So remove the store EOI for the moment, until
hardware is improved.
Also, while we are at changing the XIVE source flags, let's fix the
settings for the PHB4s which should follow these rules :
- SHIFT_BUG for DD10
- STORE_EOI for DD20 and if enabled
- TRIGGER_PAGE for DDx0 and if not STORE_EOI
Signed-off-by: Cédric Le Goater <clg@kaod.org>
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Diffstat (limited to 'hw/xive.c')
| -rw-r--r-- | hw/xive.c | 13 |
1 files changed, 10 insertions, 3 deletions
@@ -487,6 +487,9 @@ struct xive { void *q_ovf; }; +#define XIVE_CAN_STORE_EOI(x) \ + (XIVE_STORE_EOI_ENABLED && ((x)->rev >= XIVE_REV_2)) + /* Global DT node */ static struct dt_node *xive_dt_node; @@ -1751,7 +1754,11 @@ static bool xive_config_init(struct xive *x) /* Enable StoreEOI */ val = xive_regr(x, VC_SBC_CONFIG); - val |= VC_SBC_CONF_CPLX_CIST | VC_SBC_CONF_CIST_BOTH; + if (XIVE_CAN_STORE_EOI(x)) + val |= VC_SBC_CONF_CPLX_CIST | VC_SBC_CONF_CIST_BOTH; + else + xive_dbg(x, "store EOI is disabled\n"); + val |= VC_SBC_CONF_NO_UPD_PRF; xive_regw(x, VC_SBC_CONFIG, val); @@ -2797,7 +2804,7 @@ void xive_register_ipi_source(uint32_t base, uint32_t count, void *data, assert(s); /* Store EOI supported on DD2.0 */ - if (x->rev >= XIVE_REV_2) + if (XIVE_CAN_STORE_EOI(x)) flags |= XIVE_SRC_STORE_EOI; /* Callbacks assume the MMIO base corresponds to the first @@ -2905,7 +2912,7 @@ static struct xive *init_one_xive(struct dt_node *np) /* Register built-in source controllers (aka IPIs) */ flags = XIVE_SRC_EOI_PAGE1 | XIVE_SRC_TRIGGER_PAGE; - if (x->rev >= XIVE_REV_2) + if (XIVE_CAN_STORE_EOI(x)) flags |= XIVE_SRC_STORE_EOI; __xive_register_source(x, &x->ipis, x->int_base, x->int_hw_bot - x->int_base, IPI_ESB_SHIFT, |