diff options
| author | Stewart Smith <stewart@linux.vnet.ibm.com> | 2015-11-10 18:38:45 +1100 |
|---|---|---|
| committer | Stewart Smith <stewart@linux.vnet.ibm.com> | 2015-11-11 10:54:37 +1100 |
| commit | a3b9e2f777649db8fe601ec5d85457b19058b6c5 (patch) | |
| tree | 311d09e9a83b27c67b8870d46ebbe929b0b9a918 /hw/lpc.c | |
| parent | 8dfdef7aef29fee1e0e48e6dbdec68371ac59b1f (diff) | |
| download | skiboot-a3b9e2f777649db8fe601ec5d85457b19058b6c5.zip skiboot-a3b9e2f777649db8fe601ec5d85457b19058b6c5.tar.gz skiboot-a3b9e2f777649db8fe601ec5d85457b19058b6c5.tar.bz2 | |
llvm-scan-build: fix dead assignment in hw/lpc.c
hw/lpc.c:533:3: warning: Value stored to 'rc' is never read
rc = opb_read(chip, lpc_reg_opb_base + LPC_HC_IRQMASK, &val, 4);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
hw/lpc.c:535:3: warning: Value stored to 'rc' is never read
rc = opb_read(chip, lpc_reg_opb_base + LPC_HC_IRQSER_CTRL, &val, 4);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Diffstat (limited to 'hw/lpc.c')
| -rw-r--r-- | hw/lpc.c | 11 |
1 files changed, 9 insertions, 2 deletions
@@ -531,9 +531,16 @@ static void lpc_setup_serirq(struct proc_chip *chip) { u32 val; rc = opb_read(chip, lpc_reg_opb_base + LPC_HC_IRQMASK, &val, 4); - DBG_IRQ("LPC: MASK READBACK=%x\n", val); + if (rc) + prerror("LPC: failed to readback mask"); + else + DBG_IRQ("LPC: MASK READBACK=%x\n", val); + rc = opb_read(chip, lpc_reg_opb_base + LPC_HC_IRQSER_CTRL, &val, 4); - DBG_IRQ("LPC: CTRL READBACK=%x\n", val); + if (rc) + prerror("LPC: failed to readback ctrl"); + else + DBG_IRQ("LPC: CTRL READBACK=%x\n", val); } } |