diff options
| author | Stewart Smith <stewart@linux.vnet.ibm.com> | 2016-06-22 15:42:40 +1000 |
|---|---|---|
| committer | Stewart Smith <stewart@linux.vnet.ibm.com> | 2016-06-24 15:50:12 +1000 |
| commit | 591dcb04f4d1e5a08b58286117f8d9070d56b0ef (patch) | |
| tree | 350f3840ae9b8732dc2ac77cf4fb088ad84657b8 /hw/ipmi | |
| parent | c04c5945fd30bde9a15e5969cee2023126b933cc (diff) | |
| download | skiboot-591dcb04f4d1e5a08b58286117f8d9070d56b0ef.zip skiboot-591dcb04f4d1e5a08b58286117f8d9070d56b0ef.tar.gz skiboot-591dcb04f4d1e5a08b58286117f8d9070d56b0ef.tar.bz2 | |
ipmi-sel: Add FWTS annotations for some errors
Namely around PNOR access requests and OCC reset.
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Diffstat (limited to 'hw/ipmi')
| -rw-r--r-- | hw/ipmi/ipmi-sel.c | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/hw/ipmi/ipmi-sel.c b/hw/ipmi/ipmi-sel.c index 6bc386a..fa888a8 100644 --- a/hw/ipmi/ipmi-sel.c +++ b/hw/ipmi/ipmi-sel.c @@ -468,6 +468,12 @@ static void sel_pnor(uint8_t access) occ_pnor_set_owner(PNOR_OWNER_HOST); break; default: + /** + * @fwts-label InvalidPNORAccessRequest + * @fwts-advice In negotiating PNOR access with BMC, we + * got an odd/invalid request from the BMC. Likely a bug + * in OPAL/BMC interaction. + */ prlog(PR_ERR, "invalid PNOR access requested: %02x\n", access); } @@ -517,6 +523,10 @@ static void sel_occ_reset(uint8_t sensor) rc = occ_sensor_id_to_chip(sensor, &chip); if (rc) { + /** + * @fwts-label: SELUnknownOCCReset + * @fwts-advice: Likely bug in what sent us the OCC reset. + */ prlog(PR_ERR, "SEL message to reset an unknown OCC " "(sensor ID 0x%02x)\n", sensor); return; |