diff options
| author | Stewart Smith <stewart@linux.ibm.com> | 2019-02-25 16:24:35 +1100 |
|---|---|---|
| committer | Stewart Smith <stewart@linux.ibm.com> | 2019-02-25 21:59:03 -0600 |
| commit | 039d184dda211fc5d8c64457d006111a0178f293 (patch) | |
| tree | 1063447671b7698eb3cfdb711260a58d45c297bb /hw/imc.c | |
| parent | 655e0bc6865c17883230887d203fd0946d8c93f0 (diff) | |
| download | skiboot-039d184dda211fc5d8c64457d006111a0178f293.zip skiboot-039d184dda211fc5d8c64457d006111a0178f293.tar.gz skiboot-039d184dda211fc5d8c64457d006111a0178f293.tar.bz2 | |
sparse: symbols in imc.c weren't declared, Should they be static?
Yes, a bunch of these should be.
Signed-off-by: Stewart Smith <stewart@linux.ibm.com>
Diffstat (limited to 'hw/imc.c')
| -rw-r--r-- | hw/imc.c | 12 |
1 files changed, 6 insertions, 6 deletions
@@ -1,4 +1,4 @@ -/* Copyright 2016 IBM Corp. +/* Copyright 2016-2019 IBM Corp. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -27,7 +27,7 @@ * imc_chip_avl_vector(in struct imc_chip_cb, look at include/imc.h). * nest_pmus[] is an array containing all the possible nest IMC PMU node names. */ -char const *nest_pmus[] = { +static char const *nest_pmus[] = { "powerbus0", "mcs0", "mcs1", @@ -89,7 +89,7 @@ char const *nest_pmus[] = { * in the debug mode (which will be supported by microcode in the future). * These will be advertised only when OPAL provides interface for the it. */ -char const *debug_mode_units[] = { +static char const *debug_mode_units[] = { "mcs0", "mcs1", "mcs2", @@ -116,7 +116,7 @@ static struct combined_units_node cu_node[] = { static char *compress_buf; static size_t compress_buf_size; const char **prop_to_fix(struct dt_node *node); -const char *props_to_fix[] = {"events", NULL}; +static const char *props_to_fix[] = {"events", NULL}; static bool is_nest_mem_initialized(struct imc_chip_cb *ptr) { @@ -136,13 +136,13 @@ static bool is_nest_mem_initialized(struct imc_chip_cb *ptr) * SCOM port addresses in the arrays below, each for Hardware Trace Macro (HTM) * mode and PDBAR. */ -unsigned int pdbar_scom_index[] = { +static unsigned int pdbar_scom_index[] = { 0x1001220B, 0x1001230B, 0x1001260B, 0x1001270B }; -unsigned int htm_scom_index[] = { +static unsigned int htm_scom_index[] = { 0x10012200, 0x10012300, 0x10012600, |