diff options
| author | Aruna Balakrishnaiah <aruna@linux.vnet.ibm.com> | 2014-09-09 12:26:18 +0530 |
|---|---|---|
| committer | Stewart Smith <stewart@linux.vnet.ibm.com> | 2014-10-15 17:50:33 +1100 |
| commit | e786bde299d9b96078e72f0514251e13b7e8f71b (patch) | |
| tree | 51c1f901bd4f25052363d74f64e4bd9cee4f32a8 /hw/fsp | |
| parent | a595873b113c60778ca6cd71d62cd7942c80de23 (diff) | |
| download | skiboot-e786bde299d9b96078e72f0514251e13b7e8f71b.zip skiboot-e786bde299d9b96078e72f0514251e13b7e8f71b.tar.gz skiboot-e786bde299d9b96078e72f0514251e13b7e8f71b.tar.bz2 | |
attn: Remove generate_hex_word macro
Remove generate_hex_word macro and do the masking inline.
This is just a code cleanup.
Signed-off-by: Aruna Balakrishnaiah <aruna@linux.vnet.ibm.com>
Acked-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Reviewed-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Diffstat (limited to 'hw/fsp')
| -rw-r--r-- | hw/fsp/fsp-attn.c | 9 |
1 files changed, 2 insertions, 7 deletions
diff --git a/hw/fsp/fsp-attn.c b/hw/fsp/fsp-attn.c index 9edc920..2ac38c6 100644 --- a/hw/fsp/fsp-attn.c +++ b/hw/fsp/fsp-attn.c @@ -47,11 +47,6 @@ */ #define TI_SRC_LEN 0x48 -/* Generate hex word from assert function's address - * 4 bytes used for assert function call address - */ -#define generate_hex_word(addr) (addr & 0xffffffff) - static struct ti_attn *ti_attn; /* Initialises SP attention area with default values */ @@ -82,7 +77,7 @@ static void init_sp_attn_area(void) /* #HEX words */ ti_attn->hex_cnt = TI_HEX_WORDS; ti_attn->src_len = CPU_TO_BE16(TI_SRC_LEN); - sprintf(ti_attn->src, "%X", generate_src_from_comp(OPAL_RC_ATTN)); + snprintf(ti_attn->src, SRC_LEN, "%X", generate_src_from_comp(OPAL_RC_ATTN)); } /* Updates src in sp attention area @@ -93,7 +88,7 @@ void update_sp_attn_area(const char *msg) return; ti_attn->src_word[0] = - (uint32_t)generate_hex_word((uint64_t)__builtin_return_address(0)); + (uint32_t)((uint64_t)__builtin_return_address(0) & 0xffffffff); snprintf(ti_attn->msg.gitid, GITID_LEN, "%s", gitid); __backtrace(ti_attn->msg.bt_buf, BT_FRAME_LEN); |