diff options
author | Stewart Smith <stewart@linux.vnet.ibm.com> | 2016-04-27 07:49:05 +1000 |
---|---|---|
committer | Stewart Smith <stewart@linux.vnet.ibm.com> | 2016-04-27 07:49:05 +1000 |
commit | d729ddbfd8cb7b5dc60f336bf7208214c96a3233 (patch) | |
tree | 2985145a2d7cf359f8e9d4cb6d0aa2cebc4eeca8 /hw/fsp | |
parent | d597168a0ea6958955a2a2fc845354059fd057c2 (diff) | |
parent | c8bea6e01608f77550ef686bb7359094311de810 (diff) | |
download | skiboot-d729ddbfd8cb7b5dc60f336bf7208214c96a3233.zip skiboot-d729ddbfd8cb7b5dc60f336bf7208214c96a3233.tar.gz skiboot-d729ddbfd8cb7b5dc60f336bf7208214c96a3233.tar.bz2 |
Merge branch 'skiboot-5.1.x' into skiboot-5.2.x
Merge PHB3 race fix
Diffstat (limited to 'hw/fsp')
-rw-r--r-- | hw/fsp/fsp-ipmi.c | 16 |
1 files changed, 13 insertions, 3 deletions
diff --git a/hw/fsp/fsp-ipmi.c b/hw/fsp/fsp-ipmi.c index 750d144..f803f17 100644 --- a/hw/fsp/fsp-ipmi.c +++ b/hw/fsp/fsp-ipmi.c @@ -50,6 +50,10 @@ DEFINE_LOG_ENTRY(OPAL_RC_IPMI_RESP, OPAL_PLATFORM_ERR_EVT, OPAL_IPMI, OPAL_PLATFORM_FIRMWARE, OPAL_PREDICTIVE_ERR_GENERAL, OPAL_NA); +DEFINE_LOG_ENTRY(OPAL_RC_IPMI_DMA_ERROR_RESP, OPAL_PLATFORM_ERR_EVT, OPAL_IPMI, + OPAL_PLATFORM_FIRMWARE, OPAL_INFO, + OPAL_NA); + struct fsp_ipmi_msg { struct list_node link; struct ipmi_msg ipmi_msg; @@ -281,13 +285,19 @@ static bool fsp_ipmi_read_response(struct fsp_msg *msg) assert(msg->data.words[1] == PSI_DMA_PLAT_RESP_BUF); if (status != FSP_STATUS_SUCCESS) { - log_simple_error(&e_info(OPAL_RC_IPMI_RESP), "IPMI: Response " - "with bad status:0x%02x\n", status); + if(status == FSP_STATUS_DMA_ERROR) + log_simple_error(&e_info(OPAL_RC_IPMI_DMA_ERROR_RESP), "IPMI: Received " + "DMA ERROR response from FSP, this may be due to FSP " + "is in termination state:0x%02x\n", status); + else + log_simple_error(&e_info(OPAL_RC_IPMI_RESP), "IPMI: FSP response " + "received with bad status:0x%02x\n", status); + fsp_ipmi_cmd_done(ipmi_msg->cmd, IPMI_NETFN_RETURN_CODE(ipmi_msg->netfn), IPMI_ERR_UNSPECIFIED); return fsp_ipmi_send_response(FSP_RSP_PLAT_DATA | - FSP_STATUS_GENERIC_ERROR); + FSP_STATUS_SUCCESS); } /* KCS response message format */ |