diff options
| author | Stewart Smith <stewart@linux.vnet.ibm.com> | 2016-06-23 15:46:31 +1000 |
|---|---|---|
| committer | Stewart Smith <stewart@linux.vnet.ibm.com> | 2016-06-24 15:50:12 +1000 |
| commit | 7abacff2f9a337f454f122ecae43f810ddac1adf (patch) | |
| tree | cd1f873baed025ec4ac312fb669ded1b2df0c371 /hw/fsp | |
| parent | 591dcb04f4d1e5a08b58286117f8d9070d56b0ef (diff) | |
| download | skiboot-7abacff2f9a337f454f122ecae43f810ddac1adf.zip skiboot-7abacff2f9a337f454f122ecae43f810ddac1adf.tar.gz skiboot-7abacff2f9a337f454f122ecae43f810ddac1adf.tar.bz2 | |
fsp-epow: add FWTS annotation
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Diffstat (limited to 'hw/fsp')
| -rw-r--r-- | hw/fsp/fsp-epow.c | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/hw/fsp/fsp-epow.c b/hw/fsp/fsp-epow.c index df36c46..512a15c 100644 --- a/hw/fsp/fsp-epow.c +++ b/hw/fsp/fsp-epow.c @@ -69,6 +69,10 @@ static void fsp_process_epow(struct fsp_msg *msg, int epow_type) /* Basic EPOW signature */ if (msg->data.bytes[0] != 0xF2) { + /** + * @fwts-label EPOWSignatureMismatch + * @fwts-advice Bug in skiboot/FSP code for EPOW event handling + */ prlog(PR_ERR, "Signature mismatch\n"); return; } @@ -105,6 +109,12 @@ static void fsp_process_epow(struct fsp_msg *msg, int epow_type) if (epow_changed) { rc = opal_queue_msg(OPAL_MSG_EPOW, NULL, NULL); if (rc) { + /** + * @fwts-label EPOWMessageQueueFailed + * @fwts-advice Queueing a message from OPAL to FSP + * failed. This is likely due to either an OPAL bug + * or the FSP going away. + */ prlog(PR_ERR, "OPAL EPOW message queuing failed\n"); return; } |