diff options
| author | Stewart Smith <stewart@linux.vnet.ibm.com> | 2016-06-24 14:42:38 +1000 |
|---|---|---|
| committer | Stewart Smith <stewart@linux.vnet.ibm.com> | 2016-06-24 15:50:13 +1000 |
| commit | 31755269b67853f75b8340fa452b562c072c9b5d (patch) | |
| tree | 5fc5b648d66a4d35d2115b149101cbdbf22cdd33 /hw/fsp/fsp-elog-write.c | |
| parent | e5b3277fdaae21234195a7dea6e1e2ecf028d0c3 (diff) | |
| download | skiboot-31755269b67853f75b8340fa452b562c072c9b5d.zip skiboot-31755269b67853f75b8340fa452b562c072c9b5d.tar.gz skiboot-31755269b67853f75b8340fa452b562c072c9b5d.tar.bz2 | |
fsp-elog: add FWTS annotations for several errors
These errors are essentially assert()s - something has gone wrong and
it's likely because of a bug somewhere. Things we should *never* it
regards to inconsistency, so have FWTS throw warnings on them.
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Diffstat (limited to 'hw/fsp/fsp-elog-write.c')
| -rw-r--r-- | hw/fsp/fsp-elog-write.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/hw/fsp/fsp-elog-write.c b/hw/fsp/fsp-elog-write.c index 2933b97..5358823 100644 --- a/hw/fsp/fsp-elog-write.c +++ b/hw/fsp/fsp-elog-write.c @@ -136,6 +136,12 @@ bool opal_elog_info(uint64_t *opal_elog_id, uint64_t *opal_elog_size) head = list_top(&elog_write_to_host_pending, struct errorlog, link); if (!head) { + /** + * @fwts-label ElogListInconsistent + * @fwts-advice Bug in interaction between FSP and + * OPAL. The state maintained by OPAL didn't match + * what the FSP sent. + */ prlog(PR_ERR, "%s: Inconsistent internal list state !\n", __func__); |